Re: [PATCH][RFC] Add EVPD page 0x83 entries to sysfs

[James Bottomley <jbottomley@parallels.com>]

On Thu, 2014-02-06 at 14:04 +0100, Hannes Reinecke wrote:
> EVPD page 0x83 is used to uniquely identify the device.
> So instead of having each and every program issue a separate
> SG_IO call to retrieve this information it does make far more
> sense to display it in sysfs.

Can someone please tell me what actual benefits we get from retrieving
an parsing this in the kernel instead of in userspace.  Just adding more
heuristics made your code grow by 150% since Thursday.  I'm really
worried about incomplete heuristics in the kernel because the process
for updating them is much more involved than simply doing an update to a
user package.

Please define what you're trying to achieve first, because if it's just
the best persistent name for the device it might be better to reverse
all of this and have a user writeable field in SCSI that udev populates
after it does all the heuristic stuff.  Is it a range (like name +
transport ID + other stuff) in which case we might get additional plug
ins to do that.

James