From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: [PATCH 2/3] Add EVPD page 0x83 to sysfs Date: Fri, 07 Mar 2014 14:40:00 +0400 Message-ID: <1394188800.5225.41.camel@dabdike> References: <1392286032-85036-1-git-send-email-hare@suse.de> <1392286032-85036-3-git-send-email-hare@suse.de> <20140228170131.GA31510@infradead.org> <5316D459.6070107@suse.de> <20140305194255.GA5607@infradead.org> <53183951.7080805@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from bedivere.hansenpartnership.com ([66.63.167.143]:38326 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752496AbaCGKkE (ORCPT ); Fri, 7 Mar 2014 05:40:04 -0500 In-Reply-To: <53183951.7080805@suse.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Hannes Reinecke Cc: Christoph Hellwig , linux-scsi@vger.kernel.org, Jeremy Linton , Kay Sievers , Doug Gilbert , Kai Makisara On Thu, 2014-03-06 at 10:01 +0100, Hannes Reinecke wrote: > So the only 'proper' solution would be to add a bitmap of supported > pages; however, this would be 256 bits = 32 bytes of additional > space required for struct sdev. > Which I'm a bit reluctant do to, as it'll be a sparse array in most > cases, adding to quite some wasted space. Why per sdev? Isn't it per target? The supported EVPD page list shouldn't really vary for luns of the same target unless something very strange is happening in the array. James