From: Ewan Milne <emilne@redhat.com>
To: Arvind Kumar <arvindkumar@vmware.com>
Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org,
pv-drivers@vmware.com
Subject: Re: [PATCH 1/3] VMW_PVSCSI: Fix pvscsi_abort() function.
Date: Mon, 10 Mar 2014 09:13:18 -0400 [thread overview]
Message-ID: <1394457198.3827.270.camel@localhost.localdomain> (raw)
In-Reply-To: <1394311872.8462.20.camel@arvindkumar-dev1.eng.vmware.com>
On Sat, 2014-03-08 at 12:51 -0800, Arvind Kumar wrote:
> This change ensures that pvscsi_abort() function returns SUCCESS
> only when the command in question was actually completed, otherwise
> returns FAILURE. The code before change, was causing a bug where
> driver tries to complete a command to the mid-layer while the mid-layer
> has already requested the driver to abort that command, in response
> to which the driver has responded with SUCCESS causing mid-layer
> to free the command struct.
>
> Signed-off-by: Arvind Kumar <arvindkumar@vmware.com>
> Cc: Ewan Milne <emilne@redhat.com>
This patch was verified by an OEM to fix a crash involving a double
completion. The vmw_pvscsi driver was completing an scmd after having
previously returned SUCCESS status on the scmd from .eh_abort_handler().
Acked-by: Ewan D. Milne <emilne@redhat.com>
prev parent reply other threads:[~2014-03-10 13:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 20:51 [PATCH 1/3] VMW_PVSCSI: Fix pvscsi_abort() function Arvind Kumar
2014-03-10 13:13 ` Ewan Milne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394457198.3827.270.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=JBottomley@parallels.com \
--cc=arvindkumar@vmware.com \
--cc=linux-scsi@vger.kernel.org \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox