From: Joe Perches <joe@perches.com>
To: Matei Oprea <eu@opreamatei.ro>
Cc: JBottomley@parallels.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
ROSEdu Kernel Community <firefly@lists.rosedu.org>
Subject: Re: [PATCH] Scsi: lpfc: lpfc_init: Remove useless casting value
Date: Wed, 12 Mar 2014 14:35:37 -0700 [thread overview]
Message-ID: <1394660137.3915.58.camel@joe-AO722> (raw)
In-Reply-To: <1394659247-20037-1-git-send-email-eu@opreamatei.ro>
On Wed, 2014-03-12 at 23:20 +0200, Matei Oprea wrote:
> Remove useless casting value returned by k[cmz]alloc
> to (struct lpfc_sli_ring *).
>
> Found using coccinelle
trivial note:
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
[]
> @@ -4731,8 +4731,7 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba)
[]
> - phba->sli.ring = (struct lpfc_sli_ring *)
> - kzalloc(LPFC_SLI3_MAX_RING *
> + phba->sli.ring = kzalloc(LPFC_SLI3_MAX_RING *
> sizeof(struct lpfc_sli_ring), GFP_KERNEL);
Using kcalloc would have been even nicer too
phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
sizeof(struct lpfc_sli_ring),
GFP_KERNEL);
prev parent reply other threads:[~2014-03-12 21:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 21:20 [PATCH] Scsi: lpfc: lpfc_init: Remove useless casting value Matei Oprea
2014-03-12 21:35 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394660137.3915.58.camel@joe-AO722 \
--to=joe@perches.com \
--cc=JBottomley@parallels.com \
--cc=eu@opreamatei.ro \
--cc=firefly@lists.rosedu.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox