From: Quinn Tran <quinn.tran@qlogic.com>
To: target-devel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: giridhar.malavali@qlogic.com, saurav.kashyap@qlogic.com,
andrew.vasquez@qlogic.com
Subject: [PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability
Date: Fri, 28 Mar 2014 19:05:25 -0400 [thread overview]
Message-ID: <1396047927-14189-3-git-send-email-quinn.tran@qlogic.com> (raw)
In-Reply-To: <1396047927-14189-1-git-send-email-quinn.tran@qlogic.com>
Set Protection Type(1,2,3) capabilities, Guarg type (CRC/IPchksm)
capabilities bits to let TCM core knows of HW/fabric capabilities.
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
---
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 23 +++++++++++++++++++++++
drivers/scsi/qla2xxx/tcm_qla2xxx.h | 1 +
2 files changed, 24 insertions(+)
diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
index b23a0ff..4d93081 100644
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
@@ -910,12 +910,20 @@ DEF_QLA_TPG_ATTR_BOOL(demo_mode_login_only);
DEF_QLA_TPG_ATTRIB(demo_mode_login_only);
QLA_TPG_ATTR(demo_mode_login_only, S_IRUGO | S_IWUSR);
+/*
+ * Define tcm_qla2xxx_tpg_attrib_s_t10dif_force_on
+ */
+DEF_QLA_TPG_ATTR_BOOL(t10dif_force_on);
+DEF_QLA_TPG_ATTRIB(t10dif_force_on);
+QLA_TPG_ATTR(t10dif_force_on, S_IRUGO | S_IWUSR);
+
static struct configfs_attribute *tcm_qla2xxx_tpg_attrib_attrs[] = {
&tcm_qla2xxx_tpg_attrib_generate_node_acls.attr,
&tcm_qla2xxx_tpg_attrib_cache_dynamic_acls.attr,
&tcm_qla2xxx_tpg_attrib_demo_mode_write_protect.attr,
&tcm_qla2xxx_tpg_attrib_prod_mode_write_protect.attr,
&tcm_qla2xxx_tpg_attrib_demo_mode_login_only.attr,
+ &tcm_qla2xxx_tpg_attrib_t10dif_force_on.attr,
NULL,
};
@@ -1049,6 +1057,18 @@ static struct se_portal_group *tcm_qla2xxx_make_tpg(
tpg->tpg_attrib.demo_mode_write_protect = 1;
tpg->tpg_attrib.cache_dynamic_acls = 1;
tpg->tpg_attrib.demo_mode_login_only = 1;
+ tpg->tpg_attrib.t10dif_force_on = 0;
+ tpg->se_tpg.fabric_sup_prot_type = 0;
+ tpg->se_tpg.fabric_sup_guard_type = 0;
+
+ if (scsi_host_get_prot(lport->qla_vha->host)) {
+ tpg->se_tpg.fabric_sup_prot_type = (TARGET_DIF_TYPE0_PROT|
+ TARGET_DIF_TYPE1_PROT|TARGET_DIF_TYPE2_PROT|
+ TARGET_DIF_TYPE3_PROT);
+
+ tpg->se_tpg.fabric_sup_guard_type = TARGET_GUARD_CRC|
+ TARGET_GUARD_IP;
+ }
ret = core_tpg_register(&tcm_qla2xxx_fabric_configfs->tf_ops, wwn,
&tpg->se_tpg, tpg, TRANSPORT_TPG_TYPE_NORMAL);
@@ -1127,6 +1147,8 @@ static ssize_t tcm_qla2xxx_npiv_tpg_store_enable(
qlt_stop_phase1(vha->vha_tgt.qla_tgt);
}
+ core_tpg_set_fabric_t10dif(se_tpg, tpg->tpg_attrib.t10dif_force_on);
+
return count;
}
@@ -1169,6 +1191,7 @@ static struct se_portal_group *tcm_qla2xxx_npiv_make_tpg(
tpg->tpg_attrib.demo_mode_write_protect = 1;
tpg->tpg_attrib.cache_dynamic_acls = 1;
tpg->tpg_attrib.demo_mode_login_only = 1;
+ tpg->tpg_attrib.t10dif_force_on = 0;
ret = core_tpg_register(&tcm_qla2xxx_npiv_fabric_configfs->tf_ops, wwn,
&tpg->se_tpg, tpg, TRANSPORT_TPG_TYPE_NORMAL);
diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.h b/drivers/scsi/qla2xxx/tcm_qla2xxx.h
index 33aaac8..62fdce3 100644
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.h
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.h
@@ -28,6 +28,7 @@ struct tcm_qla2xxx_tpg_attrib {
int demo_mode_write_protect;
int prod_mode_write_protect;
int demo_mode_login_only;
+ int t10dif_force_on;
};
struct tcm_qla2xxx_tpg {
--
1.8.4.GIT
next prev parent reply other threads:[~2014-03-28 23:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 23:05 [PATCH RFC 0/4] add T10-Dif registration for tcm_qla2xxx Quinn Tran
2014-03-28 23:05 ` [PATCH 1/4] target/core: T10-Dif: check HW support capabilities Quinn Tran
2014-03-29 0:05 ` sagi grimberg
2014-03-29 0:53 ` Quinn Tran
2014-03-29 1:24 ` sagi grimberg
2014-03-31 17:53 ` Quinn Tran
2014-04-01 1:19 ` Nicholas A. Bellinger
2014-04-01 7:59 ` Sagi Grimberg
2014-04-01 17:09 ` Martin K. Petersen
2014-04-01 17:27 ` sagi grimberg
2014-04-01 17:45 ` Nicholas A. Bellinger
2014-04-02 6:51 ` Sagi Grimberg
2014-04-02 18:20 ` Nicholas A. Bellinger
2014-04-03 1:18 ` Quinn Tran
2014-04-02 11:43 ` sagi grimberg
2014-04-02 18:47 ` Nicholas A. Bellinger
2014-04-01 1:03 ` Nicholas A. Bellinger
2014-03-28 23:05 ` Quinn Tran [this message]
2014-03-29 0:12 ` [PATCH 2/4] tcm_qla2xxx: T10-Dif set harware capability sagi grimberg
2014-03-31 15:38 ` Quinn Tran
2014-04-01 1:11 ` Nicholas A. Bellinger
2014-04-01 8:04 ` Sagi Grimberg
2014-04-01 17:40 ` Nicholas A. Bellinger
2014-04-02 10:26 ` sagi grimberg
2014-03-28 23:05 ` [PATCH 3/4] target/rd: T10-Dif: Add init/format support Quinn Tran
2014-03-29 0:16 ` sagi grimberg
2014-03-31 16:14 ` Quinn Tran
2014-03-28 23:05 ` [PATCH 4/4] target/rd: T10-Dif: RAM disk is allocating more space than required Quinn Tran
2014-03-29 0:22 ` sagi grimberg
2014-03-31 16:15 ` Quinn Tran
2014-04-01 0:41 ` Nicholas A. Bellinger
2014-03-28 23:48 ` [PATCH RFC 0/4] add T10-Dif registration for tcm_qla2xxx Quinn Tran
2014-03-29 0:23 ` sagi grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396047927-14189-3-git-send-email-quinn.tran@qlogic.com \
--to=quinn.tran@qlogic.com \
--cc=andrew.vasquez@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=saurav.kashyap@qlogic.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).