From: Joe Perches <joe@perches.com>
To: Matei Oprea <eu@opreamatei.ro>
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
ROSEdu Kernel Community <firefly@lists.rosedu.org>
Subject: Re: [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory
Date: Tue, 08 Apr 2014 17:04:26 -0700 [thread overview]
Message-ID: <1397001866.14321.13.camel@joe-AO722> (raw)
In-Reply-To: <1396989746-29647-1-git-send-email-eu@opreamatei.ro>
On Tue, 2014-04-08 at 23:42 +0300, Matei Oprea wrote:
> It's easier to use kcalloc for allocating arrays. While at it
> also remove useless casting value.
[]
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
[]
> @@ -4742,12 +4742,14 @@ lpfc_sli_driver_resource_setup(struct lpfc_hba *phba)
[]
> - if (!phba->sli.ring)
[]
> + if (unlikely(!phba->sli.ring)) {
Why add the unlikely?
Glancing at the code it seems more like that this
should be likely than unlikely.
> + phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
> + sizeof(struct lpfc_sli_ring),
> + GFP_KERNEL);
It'd be nicer looking if aligned better
phba->sli.ring = kcalloc(LPFC_SLI3_MAX_RING,
sizeof(struct lpfc_sli_ring),
GFP_KERNEL);
next prev parent reply other threads:[~2014-04-09 0:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 20:42 [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory Matei Oprea
2014-04-09 0:04 ` Joe Perches [this message]
2014-04-09 10:48 ` Boaz Harrosh
-- strict thread matches above, loose matches on Subject: below --
2014-04-11 9:21 Matei Oprea
2014-04-08 20:18 Matei Oprea
2014-04-08 20:20 ` Joe Perches
2014-04-08 20:21 ` Matei Oprea
2014-04-08 19:44 Matei Oprea
2014-04-08 19:48 ` Joe Perches
2014-03-18 20:51 Matei Oprea
2014-04-07 12:37 ` Matei Oprea
2014-04-08 6:36 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397001866.14321.13.camel@joe-AO722 \
--to=joe@perches.com \
--cc=eu@opreamatei.ro \
--cc=firefly@lists.rosedu.org \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).