* [PATCH] scsi: fnic: use kernel's '%pM' format option to print MAC
@ 2014-04-29 14:45 Andy Shevchenko
2015-03-19 17:54 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2014-04-29 14:45 UTC (permalink / raw)
To: linux-scsi, Hiral Patel
Cc: Andy Shevchenko, Tom Tucker, Steve Wise, linux-rdma
Instead of supplying each byte through stack let's use %pM specifier.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Tom Tucker <tom@opengridcomputing.com>
Cc: Steve Wise <swise@opengridcomputing.com>
Cc: linux-rdma@vger.kernel.org
---
drivers/scsi/fnic/vnic_dev.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c
index 9795d6f..ba69d61 100644
--- a/drivers/scsi/fnic/vnic_dev.c
+++ b/drivers/scsi/fnic/vnic_dev.c
@@ -499,10 +499,7 @@ void vnic_dev_add_addr(struct vnic_dev *vdev, u8 *addr)
err = vnic_dev_cmd(vdev, CMD_ADDR_ADD, &a0, &a1, wait);
if (err)
- printk(KERN_ERR
- "Can't add addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n",
- addr[0], addr[1], addr[2], addr[3], addr[4], addr[5],
- err);
+ pr_err("Can't add addr [%pM], %d\n", addr, err);
}
void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr)
@@ -517,10 +514,7 @@ void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr)
err = vnic_dev_cmd(vdev, CMD_ADDR_DEL, &a0, &a1, wait);
if (err)
- printk(KERN_ERR
- "Can't del addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n",
- addr[0], addr[1], addr[2], addr[3], addr[4], addr[5],
- err);
+ pr_err("Can't del addr [%pM], %d\n", addr, err);
}
int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr)
--
1.9.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: fnic: use kernel's '%pM' format option to print MAC
2014-04-29 14:45 [PATCH] scsi: fnic: use kernel's '%pM' format option to print MAC Andy Shevchenko
@ 2015-03-19 17:54 ` Andy Shevchenko
[not found] ` <1426787642.14897.375.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2015-03-19 17:54 UTC (permalink / raw)
To: linux-scsi; +Cc: Hiral Patel, Tom Tucker, Steve Wise, linux-rdma
On Tue, 2014-04-29 at 17:45 +0300, Andy Shevchenko wrote:
> Instead of supplying each byte through stack let's use %pM specifier.
Anyone to comment or apply this patch?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Tom Tucker <tom@opengridcomputing.com>
> Cc: Steve Wise <swise@opengridcomputing.com>
> Cc: linux-rdma@vger.kernel.org
> ---
> drivers/scsi/fnic/vnic_dev.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c
> index 9795d6f..ba69d61 100644
> --- a/drivers/scsi/fnic/vnic_dev.c
> +++ b/drivers/scsi/fnic/vnic_dev.c
> @@ -499,10 +499,7 @@ void vnic_dev_add_addr(struct vnic_dev *vdev, u8 *addr)
>
> err = vnic_dev_cmd(vdev, CMD_ADDR_ADD, &a0, &a1, wait);
> if (err)
> - printk(KERN_ERR
> - "Can't add addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n",
> - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5],
> - err);
> + pr_err("Can't add addr [%pM], %d\n", addr, err);
> }
>
> void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr)
> @@ -517,10 +514,7 @@ void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr)
>
> err = vnic_dev_cmd(vdev, CMD_ADDR_DEL, &a0, &a1, wait);
> if (err)
> - printk(KERN_ERR
> - "Can't del addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n",
> - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5],
> - err);
> + pr_err("Can't del addr [%pM], %d\n", addr, err);
> }
>
> int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr)
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: fnic: use kernel's '%pM' format option to print MAC
[not found] ` <1426787642.14897.375.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
@ 2015-03-20 2:50 ` Tom Tucker
[not found] ` <550B8B0D.6010901-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Tom Tucker @ 2015-03-20 2:50 UTC (permalink / raw)
To: Andy Shevchenko, linux-scsi-u79uwXL29TY76Z2rM5mHXA
Cc: Hiral Patel, Steve Wise, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Hi Andy,
On 3/19/15 12:54 PM, Andy Shevchenko wrote:
> On Tue, 2014-04-29 at 17:45 +0300, Andy Shevchenko wrote:
>> Instead of supplying each byte through stack let's use %pM specifier.
> Anyone to comment or apply this patch?
>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
>> Cc: Tom Tucker <tom-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
>> Cc: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
>> Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> ---
>> drivers/scsi/fnic/vnic_dev.c | 10 ++--------
>> 1 file changed, 2 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c
>> index 9795d6f..ba69d61 100644
>> --- a/drivers/scsi/fnic/vnic_dev.c
>> +++ b/drivers/scsi/fnic/vnic_dev.c
>> @@ -499,10 +499,7 @@ void vnic_dev_add_addr(struct vnic_dev *vdev, u8 *addr)
>>
>> err = vnic_dev_cmd(vdev, CMD_ADDR_ADD, &a0, &a1, wait);
>> if (err)
>> - printk(KERN_ERR
>> - "Can't add addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n",
>> - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5],
>> - err);
>> + pr_err("Can't add addr [%pM], %d\n", addr, err);
This looks completely reasonable to me.
Tom
>> }
>>
>> void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr)
>> @@ -517,10 +514,7 @@ void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr)
>>
>> err = vnic_dev_cmd(vdev, CMD_ADDR_DEL, &a0, &a1, wait);
>> if (err)
>> - printk(KERN_ERR
>> - "Can't del addr [%02x:%02x:%02x:%02x:%02x:%02x], %d\n",
>> - addr[0], addr[1], addr[2], addr[3], addr[4], addr[5],
>> - err);
>> + pr_err("Can't del addr [%pM], %d\n", addr, err);
>> }
>>
>> int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr)
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: fnic: use kernel's '%pM' format option to print MAC
[not found] ` <550B8B0D.6010901-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
@ 2015-09-30 17:17 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2015-09-30 17:17 UTC (permalink / raw)
To: Tom Tucker, linux-scsi-u79uwXL29TY76Z2rM5mHXA
Cc: Hiral Patel, Steve Wise, linux-rdma-u79uwXL29TY76Z2rM5mHXA
On Thu, 2015-03-19 at 21:50 -0500, Tom Tucker wrote:
> Hi Andy,
>
> On 3/19/15 12:54 PM, Andy Shevchenko wrote:
> > On Tue, 2014-04-29 at 17:45 +0300, Andy Shevchenko wrote:
> > > Instead of supplying each byte through stack let's use %pM
> > > specifier.
> > Anyone to comment or apply this patch?
> >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org
> > > >
> > > Cc: Tom Tucker <tom-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > > Cc: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> > > Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > > ---
> > > drivers/scsi/fnic/vnic_dev.c | 10 ++--------
> > > 1 file changed, 2 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/drivers/scsi/fnic/vnic_dev.c
> > > b/drivers/scsi/fnic/vnic_dev.c
> > > index 9795d6f..ba69d61 100644
> > > --- a/drivers/scsi/fnic/vnic_dev.c
> > > +++ b/drivers/scsi/fnic/vnic_dev.c
> > > @@ -499,10 +499,7 @@ void vnic_dev_add_addr(struct vnic_dev
> > > *vdev, u8 *addr)
> > >
> > > err = vnic_dev_cmd(vdev, CMD_ADDR_ADD, &a0, &a1, wait);
> > > if (err)
> > > - printk(KERN_ERR
> > > - "Can't add addr
> > > [%02x:%02x:%02x:%02x:%02x:%02x], %d\n",
> > > - addr[0], addr[1], addr[2], addr[3],
> > > addr[4], addr[5],
> > > - err);
> > > + pr_err("Can't add addr [%pM], %d\n", addr, err);
>
> This looks completely reasonable to me.
Anyone to apply then?
>
> Tom
> > > }
> > >
> > > void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr)
> > > @@ -517,10 +514,7 @@ void vnic_dev_del_addr(struct vnic_dev
> > > *vdev, u8 *addr)
> > >
> > > err = vnic_dev_cmd(vdev, CMD_ADDR_DEL, &a0, &a1, wait);
> > > if (err)
> > > - printk(KERN_ERR
> > > - "Can't del addr
> > > [%02x:%02x:%02x:%02x:%02x:%02x], %d\n",
> > > - addr[0], addr[1], addr[2], addr[3],
> > > addr[4], addr[5],
> > > - err);
> > > + pr_err("Can't del addr [%pM], %d\n", addr, err);
> > > }
> > >
> > > int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr)
> >
>
--
Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-30 17:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-29 14:45 [PATCH] scsi: fnic: use kernel's '%pM' format option to print MAC Andy Shevchenko
2015-03-19 17:54 ` Andy Shevchenko
[not found] ` <1426787642.14897.375.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-03-20 2:50 ` Tom Tucker
[not found] ` <550B8B0D.6010901-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2015-09-30 17:17 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).