From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Maurizio Lombardi <mlombard@redhat.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_lib: replace ambiguous "Unhandled error code" messages.
Date: Wed, 28 May 2014 18:27:52 +0400 [thread overview]
Message-ID: <1401287272.2288.29.camel@dabdike> (raw)
In-Reply-To: <20140528110018.GA30751@infradead.org>
On Wed, 2014-05-28 at 04:00 -0700, Christoph Hellwig wrote:
> On Mon, May 26, 2014 at 09:27:15PM +0200, Maurizio Lombardi wrote:
> > > How about simple not setting description at all for this case?
> > >
> >
> > It has already been proposed before but James didn't like the idea.
> >
> > http://markmail.org/message/dumujpz4gfp3s4fp#query:+page:1+mid:dumujpz4gfp3s4fp+state:results
>
> James never replied to Robs question. I can't think of any value add
> that "Unhandled XYZ" adds when we already get a usesul message from the
> same error.
>
> James, care to comment what'd you like to see printed here?
I'm happy with eliminating "Unhanndled Error Code" because that is
misleading ... we should only get there if we have a DID_X return and
they're all fatal errors which will be printed.
I'm less happy removing "Unhandled Sense Code". The danger is that we
get some harmless sense code we should have handled and instead error
the command. Since for this error we know the next print will be the
sense code, what about changing it to "Failing Command with sense code:"
James
next prev parent reply other threads:[~2014-05-28 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 10:13 [PATCH] scsi_lib: replace ambiguous "Unhandled error code" messages Maurizio Lombardi
2014-05-26 16:25 ` Christoph Hellwig
2014-05-26 19:27 ` Maurizio Lombardi
2014-05-28 11:00 ` Christoph Hellwig
2014-05-28 14:27 ` James Bottomley [this message]
2014-06-06 7:32 ` Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401287272.2288.29.camel@dabdike \
--to=james.bottomley@hansenpartnership.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).