From: Maurizio Lombardi <mlombard@redhat.com>
To: James.Bottomley@HansenPartnership.com
Cc: linux-scsi@vger.kernel.org, hch@infradead.org
Subject: [PATCH V2] scsi_lib: removes ambiguous "Unhandled error code" messages.
Date: Fri, 6 Jun 2014 10:10:35 +0200 [thread overview]
Message-ID: <1402042235-7246-1-git-send-email-mlombard@redhat.com> (raw)
During IO with fabric faults, one generally sees several "Unhandled error
code" messages in the syslog as shown below:
sd 4:0:6:2: [sdbw] Unhandled error code
sd 4:0:6:2: [sdbw] Result: hostbyte=DID_NO_CONNECT driverbyte=DRIVER_OK
sd 4:0:6:2: [sdbw] CDB: Read(10): 28 00 00 00 00 00 00 00 08 00
end_request: I/O error, dev sdbw, sector 0
This comes from scsi_io_completion (in scsi_lib.c) while handling error
codes other than DID_RESET or not deferred sense keys i.e. this is
actually handled by the SCSI mid layer. But what gets displayed here is
"Unhandled error code" which is quite misleading as it indicates
something that is not addressed by the mid layer.
This patch removes "Unhandled error code" and replaces "Unhandled sense code"
with "Failing command with sense code:".
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
drivers/scsi/scsi_lib.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 9db097a..b3c25cd 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -955,14 +955,12 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
action = ACTION_FAIL;
break;
default:
- description = "Unhandled sense code";
+ description = "Failing command with sense code:";
action = ACTION_FAIL;
break;
}
- } else {
- description = "Unhandled error code";
+ } else
action = ACTION_FAIL;
- }
if (action != ACTION_FAIL &&
time_before(cmd->jiffies_at_alloc + wait_for, jiffies)) {
--
Maurizio Lombardi
next reply other threads:[~2014-06-06 8:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 8:10 Maurizio Lombardi [this message]
2014-06-06 14:12 ` [PATCH V2] scsi_lib: removes ambiguous "Unhandled error code" messages Christoph Hellwig
2014-06-25 11:06 ` Christoph Hellwig
2014-06-25 20:38 ` Elliott, Robert (Server Storage)
2014-07-03 8:41 ` Christoph Hellwig
2014-07-08 8:36 ` Maurizio Lombardi
2014-07-09 10:49 ` Hannes Reinecke
2014-06-25 17:41 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402042235-7246-1-git-send-email-mlombard@redhat.com \
--to=mlombard@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).