From: Vasu Dev <vasu.dev@linux.intel.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: "Nicholas A. Bellinger" <nab@daterainc.com>,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
fcoe-devel <fcoe-devel@open-fcoe.org>, Jun Wu <jwu@stormojo.com>
Subject: Re: [PATCH 1/2] tcm_fc: Generate TASK_SET_FULL status for DataIN failures
Date: Mon, 09 Jun 2014 10:19:15 -0700 [thread overview]
Message-ID: <1402334355.5752.118.camel@vi-devel> (raw)
In-Reply-To: <1402088534.26205.8.camel@haakon3.risingtidesystems.com>
On Fri, 2014-06-06 at 14:02 -0700, Nicholas A. Bellinger wrote:
> The break aborts the DataIN send loop and invokes ft_queue_status()
> below in an attempt to send TASK_SET_FULL status.
>
> If the ft_queue_status() -> lport->tt.seq_send() also fails, then
> -ENOMEM will be returned to the target and a delayed re-queue attempt
> will be made.
I see.
> In any event, updating the comment above to be more precise
I'm ok with leaving comment as is for now, just to avoid patch re-spin
for this after above clarification. Thanks for detailed clarification
//Vasu
next prev parent reply other threads:[~2014-06-09 17:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 23:30 [PATCH 0/2] tcm_fc: Generate TASK_SET_FULL for DataIN + response failures Nicholas A. Bellinger
2014-06-05 23:30 ` [PATCH 1/2] tcm_fc: Generate TASK_SET_FULL status for DataIN failures Nicholas A. Bellinger
2014-06-06 20:51 ` Vasu Dev
2014-06-06 21:02 ` Nicholas A. Bellinger
2014-06-09 17:19 ` Vasu Dev [this message]
2014-06-05 23:30 ` [PATCH 2/2] tcm_fc: Generate TASK_SET_FULL status for response failures Nicholas A. Bellinger
[not found] ` <1402011002-20771-3-git-send-email-nab-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
2014-06-06 21:03 ` Vasu Dev
2014-06-06 21:11 ` Nicholas A. Bellinger
2014-06-09 17:16 ` Vasu Dev
2014-06-06 20:38 ` [PATCH 0/2] tcm_fc: Generate TASK_SET_FULL for DataIN + " Vasu Dev
2014-06-06 21:09 ` Nicholas A. Bellinger
2014-06-09 17:13 ` Vasu Dev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402334355.5752.118.camel@vi-devel \
--to=vasu.dev@linux.intel.com \
--cc=fcoe-devel@open-fcoe.org \
--cc=jwu@stormojo.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@daterainc.com \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox