Re: SCSI eats error from flush failure during hot plug

Steven Haber
2014-06-26T18:13:47Z

Sure, I'll run it overnight.

On Thu, Jun 26, 2014 at 8:02 AM, Christoph Hellwig <hch@infradead.org> wrote:
> Hi Steven,
>
> can you test the patch below?
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index f7e3163..9b56e48 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -733,6 +733,14 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
> scsi_next_command(cmd);
> return;
> }
> + } else if (req->cmd_flags & REQ_FLUSH) {
> + /*
> + * Flush request don't transfer data, so we can't try
> + * to complete the good bytes first before checking
> + * the error.
> + */
> + if (result && !sense_deferred)
> + error = __scsi_error_from_host_byte(cmd, result);
> }
>
> /* no bidi support for !REQ_TYPE_BLOCK_PC yet */