Re: SCSI eats error from flush failure during hot plug

Christoph Hellwig
2014-06-27T07:53:31Z

On Thu, Jun 26, 2014 at 02:52:56PM -0400, James Bottomley wrote:
> OK, I give up, what memory leak (you don't actually mention it in your
> emails)? All memory handling is correctly done in unprep as far as I
> can tell.

To quote my earlier mail:

> - scsi_unprep_fn: calls ->uninit_command only for !PC request,
> so your patch introduces a leak for discard requests

This list both very clearly what we leak and why. Before 3.16 we'd
indeed call sd_unprep_fn for every kind of request, but we're
fortunately back to my old model from 10 years ago where BLOCK_PC
driver stay entirely away from the ULD as they should.