From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: SCSI eats error from flush failure during hot plug Date: Thu, 26 Jun 2014 14:52:56 -0400 Message-ID: <1403808776.6440.14.camel@dabdike> References: <1402169384.2236.18.camel@dabdike.int.hansenpartnership.com> <1402334946.2197.17.camel@dabdike.int.hansenpartnership.com> <20140611133736.GA12240@infradead.org> <1403201159.17294.13.camel@dabdike.int.hansenpartnership.com> <20140625131344.GA13094@infradead.org> <1403791367.3572.1.camel@dabdike> <20140626150055.GB11199@infradead.org> <1403795096.3572.8.camel@dabdike> <20140626150832.GA31800@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: Received: from bedivere.hansenpartnership.com ([66.63.167.143]:51124 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbaFZSxN (ORCPT ); Thu, 26 Jun 2014 14:53:13 -0400 In-Reply-To: <20140626150832.GA31800@infradead.org> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Christoph Hellwig Cc: Steven Haber , linux-scsi@vger.kernel.org, Jens Axboe On Thu, 2014-06-26 at 08:08 -0700, Christoph Hellwig wrote: > On Thu, Jun 26, 2014 at 11:04:56AM -0400, James Bottomley wrote: > > Right, but look what we do for the specials. The only difference is the > > ULD has a hook to generate the CDB. For everything else we follow the > > BLOCK_PC path, including error handling and sense data processing. > > No, we don't use the BLOCK_PC path for anything but a tiny bit of setup > code right now. We will with your patch, which will cause all kinds of > behavior change. See my last mail for the list of differences, which > includes the introduction of a major memory leak. OK, I give up, what memory leak (you don't actually mention it in your emails)? All memory handling is correctly done in unprep as far as I can tell. James