public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mike Christie <michaelc@cs.wisc.edu>,
	Alex Williamson <alex.williamson@redhat.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Sagi Grimberg <sagig@mellanox.com>,
	Nicholas Bellinger <nab@linux-iscsi.org>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>"Nicholas A.
	Bellinger" <nab@linux-iscsi.org>
Subject: Re: [PATCH 3.15 099/139] libiscsi, iser: Adjust data_length to include protection information
Date: Thu, 03 Jul 2014 11:00:07 -0700	[thread overview]
Message-ID: <1404410407.5091.9.camel@jarvis> (raw)
In-Reply-To: <20140703163310.GA21213@infradead.org>

On Thu, 2014-07-03 at 09:33 -0700, Christoph Hellwig wrote:
> On Thu, Jul 03, 2014 at 09:27:48AM -0700, Greg Kroah-Hartman wrote:
> > I copy everyone on the patch.  You were not on that patch as it doesn't
> > look like it went through your tree at all.
> 
> It went through the target tree despite exclusive touching scsi
> initiator side code.  I'm still not sure how this happened, but we
> should take care to avoid this in the future.  In addition to this
> regression due to a complete lack of testing it also caused various
> merge issues.

OK, Nic cc'd

Please explain how this commit:

commit d77e65350f2d82dfa0557707d505711f5a43c8fd
Author: Sagi Grimberg <sagig@mellanox.com>
Date:   Wed Jun 11 12:09:58 2014 +0300

    libiscsi, iser: Adjust data_length to include protection information
    
    In case protection information exists over the wire
    iscsi header data length is required to include it.
    Use protection information aware scsi helpers to set
    the correct transfer length.
    
    In order to avoid breakage, remove iser transfer length
    checks for each task as they are not always true and
    somewhat redundant anyway.
    
    Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
    Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
    Acked-by: Mike Christie <michaelc@cs.wisc.edu>
    Cc: stable@vger.kernel.org # 3.15+
    Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

 drivers/infiniband/ulp/iser/iser_initiator.c | 34 ++++++++--------------------
 drivers/scsi/libiscsi.c                      | 18 +++++++--------

Came to go through the target tree even though it's initiator only and
how come it was tagged for stable?

James

  reply	other threads:[~2014-07-03 18:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20140628174605.352098823@linuxfoundation.org>
     [not found] ` <20140628174609.930049472@linuxfoundation.org>
     [not found]   ` <1404339330.1862.69.camel@ul30vt.home>
2014-07-02 22:44     ` [PATCH 3.15 099/139] libiscsi, iser: Adjust data_length to include protection information Mike Christie
2014-07-02 22:48       ` Alex Williamson
2014-07-03  6:05         ` Christoph Hellwig
2014-07-02 22:52       ` James Bottomley
2014-07-02 23:19         ` Alex Williamson
2014-07-03  0:05           ` Nicholas A. Bellinger
2014-07-03  6:05         ` Christoph Hellwig
2014-07-03 13:54           ` James Bottomley
2014-07-03 16:27             ` Greg Kroah-Hartman
2014-07-03 16:33               ` Christoph Hellwig
2014-07-03 18:00                 ` James Bottomley [this message]
2014-07-06 12:27                   ` Sagi Grimberg
2014-07-03 16:28             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1404410407.5091.9.camel@jarvis \
    --to=james.bottomley@hansenpartnership.com \
    --cc=alex.williamson@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=nab@linux-iscsi.org \
    --cc=sagig@mellanox.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox