From: michaelc@cs.wisc.edu
To: linux-scsi@vger.kernel.org
Subject: [PATCH 3/4] iscsi class: fix get_host_stats return code when not supported
Date: Sat, 12 Jul 2014 15:51:50 -0500 [thread overview]
Message-ID: <1405198311-64449-4-git-send-email-michaelc@cs.wisc.edu> (raw)
In-Reply-To: <1405198311-64449-1-git-send-email-michaelc@cs.wisc.edu>
From: Mike Christie <michaelc@cs.wisc.edu>
When the get_host_stats call was not supported we were
returing EINVAL. This has us return ENOSYS, because for
software iscsi drivers where there is no host it is ok to not
have this callout.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
---
drivers/scsi/scsi_transport_iscsi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 14bfa53..534d3fb 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -3429,7 +3429,7 @@ iscsi_get_host_stats(struct iscsi_transport *transport, struct nlmsghdr *nlh)
char *buf;
if (!transport->get_host_stats)
- return -EINVAL;
+ return -ENOSYS;
priv = iscsi_if_transport_lookup(transport);
if (!priv)
--
1.7.1
next prev parent reply other threads:[~2014-07-12 20:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 20:51 [PATCH 0/4] iscsi: iscsi changes for 3.17 michaelc
2014-07-12 20:51 ` [PATCH 1/4] iscsi class: fix get_host_stats error handling michaelc
2014-07-30 12:50 ` Hannes Reinecke
2014-07-31 22:32 ` Mike Christie
2014-08-01 13:31 ` Hannes Reinecke
2014-08-01 16:10 ` Mike Christie
2014-07-12 20:51 ` [PATCH 2/4] qla4xxx: fix get_host_stats error propagation michaelc
2014-07-30 12:51 ` Hannes Reinecke
2014-07-12 20:51 ` michaelc [this message]
2014-07-30 12:52 ` [PATCH 3/4] iscsi class: fix get_host_stats return code when not supported Hannes Reinecke
2014-07-12 20:51 ` [PATCH 4/4] libiscsi: return new error code when nop times out michaelc
2014-07-30 12:52 ` Hannes Reinecke
2014-07-13 9:50 ` [PATCH 0/4] iscsi: iscsi changes for 3.17 Christoph Hellwig
2014-07-30 12:51 ` Vikas Chaudhary
2014-07-30 11:43 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405198311-64449-4-git-send-email-michaelc@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).