From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ewan Milne Subject: Re: [RFC PATCH 03/10] scsi/constants: Cleanup printk message in __scsi_print_command() Date: Fri, 15 Aug 2014 11:05:49 -0400 Message-ID: <1408115149.1223.145.camel@localhost.localdomain> References: <20140808115004.6768.97014.stgit@yuno-kbuild.novalocal> <20140808115012.6768.44952.stgit@yuno-kbuild.novalocal> Reply-To: emilne@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:37633 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751276AbaHOPGE (ORCPT ); Fri, 15 Aug 2014 11:06:04 -0400 In-Reply-To: <20140808115012.6768.44952.stgit@yuno-kbuild.novalocal> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Yoshihiro YUNOMAE Cc: Hannes Reinecke , linux-scsi@vger.kernel.org, "Martin K. Petersen" , yrl.pp-manager.tt@hitachi.com, linux-kernel@vger.kernel.org, "James E.J. Bottomley" , Hidehiro Kawai , Doug Gilbert , Masami Hiramatsu , Christoph Hellwig On Fri, 2014-08-08 at 11:50 +0000, Yoshihiro YUNOMAE wrote: > All bytes in CDB should be output after linebuf is filled because > "[%s] CDB: %s\n" message is output many times in loop. > > Signed-off-by: Yoshihiro YUNOMAE > Cc: Hannes Reinecke > Cc: Doug Gilbert > Cc: Martin K. Petersen > Cc: Christoph Hellwig > Cc: "James E.J. Bottomley" > Cc: Hidehiro Kawai > Cc: Masami Hiramatsu > --- > drivers/scsi/constants.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/scsi/constants.c b/drivers/scsi/constants.c > index 9c38b8d..5956d4d 100644 > --- a/drivers/scsi/constants.c > +++ b/drivers/scsi/constants.c > @@ -413,9 +413,8 @@ void __scsi_print_command(struct scsi_device *sdev, const char *prefix, > > hex_dump_to_buffer(cdb + i, linelen, 16, 1, > linebuf, sizeof(linebuf), false); > - sdev_printk(KERN_INFO, sdev, "[%s] CDB: %s\n", > - prefix, linebuf); > } > + sdev_printk(KERN_INFO, sdev, "[%s] CDB: %s\n", prefix, linebuf); > } > EXPORT_SYMBOL(__scsi_print_command); This doesn't look right -- In Hannes' tree what the code is doing is printing out a separate line for each 16 bytes of the CDB. You change will cause only the last (partial?) 16 bytes to be printed. -Ewan