Re: [PATCH 08/22] scsi: dump sense buffer only for debugging

Christoph Hellwig
2014-08-31T22:09:06Z

On Thu, Aug 28, 2014 at 07:33:22PM +0200, Hannes Reinecke wrote:
> Dumping the entire sense buffer might overwhelm the logging functions,
> so suppress it per default.

Call me dumb, but I don't see anything in here that limits the dumps
to debug output.

Also if you return boolean-like values please use the bool type for it.
Also please switch scsi_normalize_sense over to return bool as well
while you're at it.