Re: [PATCH 07/22] scsi: do not decode sense extras

Hannes Reinecke
2014-09-01T08:10:27Z

On 09/01/2014 12:06 AM, Christoph Hellwig wrote:
> On Thu, Aug 28, 2014 at 07:33:21PM +0200, Hannes Reinecke wrote:
>> Currently we're only decoding sense extras for tape devices.
>> And even there only for fixed format sense formats.
>> As this is of rather limited use in the general case we should
>> be stop trying to decode things here and rather dump the entire
>> sense code.
>
> I don't like this one at all. Not that I'm attached to decoding the
> extra sense buffer, but:
>
> - __scsi_print_sense now prints both decoded sense data as well as a
> full dump, which is rather ugly
> - __scsi_print_sense prints that buffer unconditionally
>
> I'd say let's sit down and work with the tape driver maintainers on
> finding a better way to deal with their sense printing needs. And part
> of that should probably be to get rid of __scsi_print_sense entirely
> and make the tape drivers use pre-decoded and normalized sense buffers.
>
Well, thing is the tape driver does it's own sense decoding anyway.
So there's no need for that to be done here.

I've updated the patch to not dump any sense code and adapted the
descriptions somewhat.

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html