Re: [PATCH 20/22] scsi: align logging messages

Hannes Reinecke
2014-09-19T11:56:28Z

On 09/19/2014 01:35 PM, Christoph Hellwig wrote:
> On Fri, Sep 19, 2014 at 08:26:29AM +0200, Hannes Reinecke wrote:
>> I would rather use 'scmd->tag', as this should be a straight copy
>> of scmd->request->tag, but we wouldn't need to reference the request
>> when doing so.
>
> Yes, for now scmd->tag is correct as drivers might not be using the
> block level tagging. Once we get rid of the legacy request path I
> plan to entirely remove scmd->tag, though.
>
>> But yeah, I was planning on doing the same, only I'd rather include
>> it right a the start like
>>
>> sd 2:0:0:3 [sdv] tag#1: abort scheduled
>
> Sounds fine.
>
>> and print out a mapping when I/O is submitted
>>
>> sd 2:0:0:3 [sdv] tag#1: scmd 0xffff880420891470
>
> I don't really see a need for that.
>
That's mainly for debugging; it gives you a nice starting point
for debugging crash dumps.
Otherwise it's really hard to get to the actual commands.

Unless you have a better idea ...

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html