Re: [PATCH 07/22] scsi: do not decode sense extras

Christoph Hellwig
2014-08-31T22:06:26Z

On Thu, Aug 28, 2014 at 07:33:21PM +0200, Hannes Reinecke wrote:
> Currently we're only decoding sense extras for tape devices.
> And even there only for fixed format sense formats.
> As this is of rather limited use in the general case we should
> be stop trying to decode things here and rather dump the entire
> sense code.

I don't like this one at all. Not that I'm attached to decoding the
extra sense buffer, but:

- __scsi_print_sense now prints both decoded sense data as well as a
full dump, which is rather ugly
- __scsi_print_sense prints that buffer unconditionally

I'd say let's sit down and work with the tape driver maintainers on
finding a better way to deal with their sense printing needs. And part
of that should probably be to get rid of __scsi_print_sense entirely
and make the tape drivers use pre-decoded and normalized sense buffers.