Re: [PATCH 17/22] scsi: print disposition in scsi_print_result()

Christoph Hellwig
2014-08-31T22:23:17Z

> +const char *
> +scsi_disposition_string(unsigned int disposition) {

The brace placement will need a fix.

> +void scsi_print_result(struct scsi_cmnd *cmd, int disposition)
> {
> const char *devname = cmd->request->rq_disk ?
> cmd->request->rq_disk->disk_name : NULL;
> - scsi_show_result(cmd->device, devname, cmd->result);
> + scsi_show_result(cmd->device, devname, cmd->result, disposition);

It seems like scsi_show_result should just take a disk argument instead
of the name one, and both scsi_print_result and sd_print_result can
just go away.