Re: [PATCH 12/22] scsi: remove obsolete __scsi_print_command() usages

Hannes Reinecke
2014-09-01T06:56:09Z

On 09/01/2014 12:18 AM, Christoph Hellwig wrote:
> Can you change the subject a bit? There's nothing obsolete in
> __scsi_print_command, you're just moving it to a higher level helper.
>
>> #if defined(AHA152X_DEBUG)
>> if (HOSTDATA(shpnt)->debug & debug_queue) {
>> - printk(INFO_LEAD "queue: %p; cmd_len=%d pieces=%d size=%u cmnd=",
>> - CMDINFO(SCpnt), SCpnt, SCpnt->cmd_len,
>> - scsi_sg_count(SCpnt), scsi_bufflen(SCpnt));
>> - __scsi_print_command(SCpnt->cmnd);
>> + scmd_printk(KERN_INFO, SCpnt,
>> + "queue: %p; cmd_len=%d pieces=%d size=%u\n",
>> + SCpnt, SCpnt->cmd_len,
>> + scsi_sg_count(SCpnt), scsi_bufflen(SCpnt));
>> + scsi_print_command(SCpnt);
>
> This also has a printk -> scmd_printk change that's unrelated to the
> patch.
>
> Honestly I think we should just kill much of the AHA152X_DEBUG code at
> the start of this series to avoid all the churn in it.
>
I'm all for it.
The 152x is a _really_ old card (that's the one which used to get
shipped with the old parallel SCSI scanner, before they switched
to ncr53c4xx) and it's ISA only. So the overall exposure will be
rather limited, and I sincerely doubt anyone will be missing the
debugging stubs.
Will be removing them with the next patchset.

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html