Re: [PATCH 13/22] scsi: use local buffer for printing the opcode

Christoph Hellwig
2014-08-31T22:19:48Z

On Thu, Aug 28, 2014 at 07:33:27PM +0200, Hannes Reinecke wrote:
> SCSI opcode printing is tricky and needs to take into account
> several different corner cases. So instead of trying to come
> up with an elaborate printk() statement we should be printing
> it into a local buffer.

scsi_print_command callers are usually deep down the call chain., so I'd
rather avoid using up even more stack here. What are the exact reasons
that we need the local buffer?