Re: [PATCH 21/22] scsi: reduce messages for command failure

Christoph Hellwig
2014-08-31T22:28:43Z

On Thu, Aug 28, 2014 at 07:33:35PM +0200, Hannes Reinecke wrote:
> When devices fail they can generate quite a lot of error
> messages, possibly overloading the logging system.
> So we should be putting these messages under logging control
> to be able to silence them if requested.
> And we should shorten the overall message; more verbose
> logging can be requested by the normal scsi logging.

While the logging mask magic always confused me I'm fairly sure this
disables logging the completion errors entirely by default. If that
was the intention it should be mentioned in the changelog.

I do however think printing them in a ratelimit way might be useful,
so I'd like to see a few more arguments for not doing it that way if
you really prefer it.