Re: [PATCH 18/20] scsi: remove scsi_show_result()

Christoph Hellwig
2014-09-07T16:17:38Z

On Wed, Sep 03, 2014 at 12:06:13PM +0200, Hannes Reinecke wrote:
> scsi_show_result() was only ever used in one place in sd.c.
> So open-code scsi_show_result() in sd.c and remove it from
> constants.c.

This does a lot more refactoring in sd.c, which needs a proper
explanation and probably splitting into a separate patch.

I also think we're much better having a different prototype
for scsi_print_result and use it here, similar to your
sdev_prefix_printk:

void scsi_print_result(struct scsi_device *sdev, const char *prefix)
{
...
}