From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: james.smart@emulex.com
Cc: Christoph Hellwig <hch@infradead.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 0/19] lpfc 10.4.8000.0: Update lpfc version to driver version 10.4.8000.0
Date: Fri, 05 Sep 2014 06:59:01 -0700 [thread overview]
Message-ID: <1409925541.2025.8.camel@jarvis.lan> (raw)
In-Reply-To: <5409BB3F.6040205@emulex.com>
On Fri, 2014-09-05 at 09:31 -0400, James Smart wrote:
> On 9/5/2014 1:35 AM, Christoph Hellwig wrote:
> > - patches that you send on with your maintainer hat on should be
> > signed off by you, not just reviewed.
>
> ok - but I guess I had a different interpretation of the meaning for
> signed-by. I thought it conveyed an ownership and originality of
> authorship of the content posted. As such, if I didn't contribute
> anything in the patch, I shouldn't give anything other than a
> reviewed-by indicating approval.
No, this is a DCO thing;the Signed-off-by: tag is the certification
under the DCO:
http://developercertificate.org/
It follows the chain of transmission, whether you alter the patch or
not, so it needs your Signed-off-by for any patch you send on behalf of
another (whether or not you alter it). By convention, you also append
your alterations to the change log in square brackets, but you don't
have to bother if it's trivial.
James
prev parent reply other threads:[~2014-09-05 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 16:54 [PATCH 0/19] lpfc 10.4.8000.0: Update lpfc version to driver version 10.4.8000.0 James Smart
2014-09-05 5:35 ` Christoph Hellwig
2014-09-05 13:31 ` James Smart
2014-09-05 13:59 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1409925541.2025.8.camel@jarvis.lan \
--to=james.bottomley@hansenpartnership.com \
--cc=hch@infradead.org \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox