Re: [PATCH 0/19] lpfc 10.4.8000.0: Update lpfc version to driver version 10.4.8000.0

James Bottomley
2014-09-05T13:59:03Z

On Fri, 2014-09-05 at 09:31 -0400, James Smart wrote:
> On 9/5/2014 1:35 AM, Christoph Hellwig wrote:
> > - patches that you send on with your maintainer hat on should be
> > signed off by you, not just reviewed.
>
> ok - but I guess I had a different interpretation of the meaning for
> signed-by. I thought it conveyed an ownership and originality of
> authorship of the content posted. As such, if I didn't contribute
> anything in the patch, I shouldn't give anything other than a
> reviewed-by indicating approval.

No, this is a DCO thing;the Signed-off-by: tag is the certification
under the DCO:

http://developercertificate.org/

It follows the chain of transmission, whether you alter the patch or
not, so it needs your Signed-off-by for any patch you send on behalf of
another (whether or not you alter it). By convention, you also append
your alterations to the change log in square brackets, but you don't
have to bother if it's trivial.

James