Re: [PATCH V4 09/17] scsi: ufs: manually add well known logical units

Christoph Hellwig
2014-09-23T08:35:32Z

None of the REPORT LUNS language makes sense as we're not using it.

Can you respon the patch with a better description, and a little comment
in the code on why you're adding these wluns.

Also can I assume none of the later patches relies on their existance?
If you do you need to check the error return from scsi_add_device, if
not said comment should mention why it's fine to not actually find
any of these.

Also if you do use one of them from kernel space later it might make
more sense to use __scsi_add_device and store a pointer to the
scsi_device instead of looking it up later.