Re: [PATCH V5 10/17] scsi: ufs: manually add well known logical units

'Christoph Hellwig'
2014-09-24T16:40:31Z

On Wed, Sep 24, 2014 at 09:36:37AM -0700, Subhash Jadavani wrote:
> Where do you release these references again? It seems like they are never
> released on the device removal path.
>
> [Subhash] That's because these are embedded/non-removable UFS devices which
> are always present on the board and never get removed. Do you have any
> suggestion on how we should handle this?

Just after the call to scsi_remove_host sounds right to me.
scsi_remove_host already removes all regularly scanned devices, but because
__scsi_add_device keeps and additional reference it doesn't free those that
you added manually.