Re: [PATCH 5/5] scsi: Remove scmd->tag

Christoph Hellwig
2014-10-02T11:22:34Z

> diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
> index a0c8c5d..cb68089 100644
> --- a/drivers/scsi/NCR5380.c
> +++ b/drivers/scsi/NCR5380.c
> @@ -1527,7 +1527,6 @@ part2:
> tmp[0] = IDENTIFY(((instance->irq == SCSI_IRQ_NONE) ? 0 : 1), cmd->device->lun);
>
> len = 1;
> - cmd->tag = 0;

The driver was explicitly setting the tag to zero here, so this needs
a good explanation instead of a blind removal.

But given how nice the code that Finn delivered in the past is I have high
hopes that his NCR5380 overhaul will get rid of a lot of this cruft :)