Re: [PATCH 1/5] NCR5380: Whitespace cleanup

Hannes Reinecke
2014-10-02T11:12:15Z

On 10/02/2014 01:07 PM, Finn Thain wrote:
>
> On Thu, 2 Oct 2014, Hannes Reinecke wrote:
>
>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>> ---
>> drivers/scsi/NCR5380.c | 652 +++++++++++++++++++++++++------------------------
>> 1 file changed, 333 insertions(+), 319 deletions(-)
>>
>
> This is going to break about 30 or 40 patches that I'm working on. Can we
> not do this yet? The white space clean up is a smaller patch if it happens
> after all the other bug fixing and modernization work.
>
Oh, you're most welcome.
I've just included it as my eyes nearly fell out when turning on
syntax highlighting.
The patch is an RFC anyway, so I doubt it'll be included in 3.18.

And indeed the NCR5380 is in dire need of modernization; having
three to four identical copies with just minor modifications
between each simply cries out for consolidation.

Thanks for doing that.

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html