Re: [PATCH 1/2] be2iscsi : Fix kernel panic during reboot/shutdown

[Ewan Milne <emilne@redhat.com>]

On Fri, 2014-09-26 at 15:13 -0400, John Soni Jose wrote:
> In the reboot/shutdown path, workqueue was destroyed after the
>  adapter resource were freed. The task associated with workqueue
>  was getting executed after resources were freed. This lead to
>  kernel panic.
> 
> Signed-off-by: John Soni Jose <sony.john-n@emulex.com>
> Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@emulex.com>
> ---
>  drivers/scsi/be2iscsi/be_main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
> index db2bd4d..30d74a0 100644
> --- a/drivers/scsi/be2iscsi/be_main.c
> +++ b/drivers/scsi/be2iscsi/be_main.c
> @@ -5223,6 +5223,7 @@ static void beiscsi_quiesce(struct beiscsi_hba *phba,
>  			free_irq(phba->pcidev->irq, phba);
>  		}
>  	pci_disable_msix(phba->pcidev);
> +	cancel_delayed_work_sync(&phba->beiscsi_hw_check_task);
>  
>  	for (i = 0; i < phba->num_cpus; i++) {
>  		pbe_eq = &phwi_context->be_eq[i];
> @@ -5244,7 +5245,6 @@ static void beiscsi_quiesce(struct beiscsi_hba *phba,
>  		hwi_cleanup(phba);
>  	}
>  
> -	cancel_delayed_work_sync(&phba->beiscsi_hw_check_task);
>  }
>  
>  static void beiscsi_remove(struct pci_dev *pcidev)

Reviewed-by: Ewan D. Milne <emilne@redhat.com>