From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <jbottomley@parallels.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Robert Elliott <elliott@hp.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 09/27] 53c700: remove scsi_print_sense() usage
Date: Fri, 24 Oct 2014 14:26:49 +0200 [thread overview]
Message-ID: <1414153627-2863-10-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1414153627-2863-1-git-send-email-hare@suse.de>
The 53c700 driver would be using scsi_print_sense() in a debug
statement, which was never compiled in. Plus the same information
can get retrieved with logging. So remove it.
Reviewed-by: Robert Elliott <elliott@hp.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/53c700.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/53c700.c b/drivers/scsi/53c700.c
index 68bf423..179a24e 100644
--- a/drivers/scsi/53c700.c
+++ b/drivers/scsi/53c700.c
@@ -592,19 +592,14 @@ NCR_700_scsi_done(struct NCR_700_Host_Parameters *hostdata,
hostdata->cmd = NULL;
if(SCp != NULL) {
- struct NCR_700_command_slot *slot =
+ struct NCR_700_command_slot *slot =
(struct NCR_700_command_slot *)SCp->host_scribble;
-
+
dma_unmap_single(hostdata->dev, slot->pCmd,
MAX_COMMAND_SIZE, DMA_TO_DEVICE);
if (slot->flags == NCR_700_FLAG_AUTOSENSE) {
char *cmnd = NCR_700_get_sense_cmnd(SCp->device);
-#ifdef NCR_700_DEBUG
- printk(" ORIGINAL CMD %p RETURNED %d, new return is %d sense is\n",
- SCp, SCp->cmnd[7], result);
- scsi_print_sense(SCp);
-#endif
dma_unmap_single(hostdata->dev, slot->dma_handle,
SCSI_SENSE_BUFFERSIZE, DMA_FROM_DEVICE);
/* restore the old result if the request sense was
--
1.8.5.2
next prev parent reply other threads:[~2014-10-24 12:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 12:26 [PATCHv8 00/27] scsi logging update (the boring part) Hannes Reinecke
2014-10-24 12:26 ` [PATCH 01/27] Remove scsi_cmd_print_sense_hdr() Hannes Reinecke
2014-10-24 12:26 ` [PATCH 02/27] sd: Remove scsi_print_sense() in sd_done() Hannes Reinecke
2014-10-24 12:26 ` [PATCH 03/27] aha152x: Debug output update and whitespace cleanup Hannes Reinecke
2014-10-24 12:26 ` [PATCH 04/27] scsi: introduce sdev_prefix_printk() Hannes Reinecke
2014-10-24 12:26 ` [PATCH 05/27] scsi: Use sdev as argument for sense code printing Hannes Reinecke
2014-10-24 12:26 ` [PATCH 06/27] acornscsi: use scsi_print_command() Hannes Reinecke
2014-10-24 12:26 ` [PATCH 07/27] fas216: Return DID_ERROR for incomplete data transfer Hannes Reinecke
2014-10-24 12:26 ` [PATCH 08/27] fas216: Update logging messages Hannes Reinecke
2014-10-24 12:26 ` Hannes Reinecke [this message]
2014-10-24 12:26 ` [PATCH 10/27] scsi: stop decoding if scsi_normalize_sense() fails Hannes Reinecke
2014-10-24 12:26 ` [PATCH 11/27] scsi: do not decode sense extras Hannes Reinecke
2014-10-24 12:26 ` [PATCH 12/27] scsi: use 'bool' as return value for scsi_normalize_sense() Hannes Reinecke
2014-10-24 12:26 ` [PATCH 13/27] scsi: remove scsi_print_status() Hannes Reinecke
2014-10-24 12:26 ` [PATCH 14/27] Implement scsi_opcode_sa_name Hannes Reinecke
2014-10-24 12:26 ` [PATCH 15/27] scsi: merge print_opcode_name() Hannes Reinecke
2014-10-24 12:26 ` [PATCH 16/27] scsi: consolidate opcode lookup in scsi_opcode_sa_name() Hannes Reinecke
2014-10-24 12:26 ` [PATCH 17/27] scsi: repurpose the last argument from print_opcode_name() Hannes Reinecke
2014-10-24 12:26 ` [PATCH 18/27] scsi: Remove scsi_print_command when calling abort Hannes Reinecke
2014-10-24 12:26 ` [PATCH 19/27] scsi: separate out scsi_(host|driver)byte_string() Hannes Reinecke
2014-10-24 12:27 ` [PATCH 20/27] Remove scsi_show_result() Hannes Reinecke
2014-10-24 12:27 ` [PATCH 21/27] scsi: simplify scsi_log_(send|completion) Hannes Reinecke
2014-10-24 12:27 ` [PATCH 22/27] scsi: fixup logging messages in scsi_error.c Hannes Reinecke
2014-10-24 12:27 ` [PATCH 23/27] scsi: use shost argument in scsi_eh_prt_fail_stats Hannes Reinecke
2014-10-24 12:27 ` [PATCH 24/27] scsi_error: document scsi_try_to_abort_cmd Hannes Reinecke
2014-10-24 12:27 ` [PATCH 25/27] scsi: check for correct return code in scsi_eh_abort_cmds() Hannes Reinecke
2014-10-28 19:04 ` Elliott, Robert (Server Storage)
2014-10-29 7:29 ` Hannes Reinecke
2014-10-24 12:27 ` [PATCH 26/27] scsi: correct return values for .eh_abort_handler implementations Hannes Reinecke
2014-10-28 23:49 ` Elliott, Robert (Server Storage)
2014-10-29 7:39 ` Hannes Reinecke
2014-10-24 12:27 ` [PATCH 27/27] scsi: ratelimit I/O error messages Hannes Reinecke
2014-10-24 21:00 ` Elliott, Robert (Server Storage)
2014-10-28 17:33 ` Christoph Hellwig
2014-10-28 17:44 ` Hannes Reinecke
2014-10-28 17:57 ` Christoph Hellwig
2014-10-28 18:36 ` Elliott, Robert (Server Storage)
2014-10-24 14:54 ` [PATCHv8 00/27] scsi logging update (the boring part) Christoph Hellwig
2014-10-28 2:23 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2014-10-20 6:52 [PATCHv7 " Hannes Reinecke
2014-10-20 6:52 ` [PATCH 09/27] 53c700: remove scsi_print_sense() usage Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414153627-2863-10-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=elliott@hp.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox