public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, wenxiong@linux.vnet.ibm.com
Subject: Re: [PATCH 1/2] ipr: Disable async aborts
Date: Mon, 27 Oct 2014 07:50:03 -0700	[thread overview]
Message-ID: <1414421403.6401.5.camel@jarvis.lan> (raw)
In-Reply-To: <201410271439.s9REdl9U017474@d01av02.pok.ibm.com>

On Mon, 2014-10-27 at 09:37 -0500, Brian King wrote:
> The ipr driver does not yet support async aborts, so disable this
> for now.
> 
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>

By "does not yet support" do you mean doesn't work with or merely not
tested with but seems to work OK?  if the former, then surely this
should be a fixes patch with a cc to stable for all the kernels async
abort is in (which is 3.14)

James

> ---
> 
>  drivers/scsi/ipr.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -puN drivers/scsi/ipr.c~ipr_no_async_eh drivers/scsi/ipr.c
> --- linux/drivers/scsi/ipr.c~ipr_no_async_eh	2014-10-24 08:57:53.169169509 -0500
> +++ linux-bjking1/drivers/scsi/ipr.c	2014-10-24 08:57:53.175169579 -0500
> @@ -6357,6 +6357,7 @@ static struct scsi_host_template driver_
>  	.sdev_attrs = ipr_dev_attrs,
>  	.proc_name = IPR_NAME,
>  	.no_write_same = 1,
> +	.no_async_abort = 1,
>  };
>  
>  /**
> _
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 



  reply	other threads:[~2014-10-27 14:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-27 14:37 [PATCH 1/2] ipr: Disable async aborts Brian King
2014-10-27 14:50 ` James Bottomley [this message]
2014-10-28  8:47   ` Christoph Hellwig
2014-10-29 21:16     ` Brian King
2014-10-30  8:17       ` Christoph Hellwig
2014-10-28 13:58   ` Brian King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1414421403.6401.5.camel@jarvis.lan \
    --to=james.bottomley@hansenpartnership.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=wenxiong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox