From: Tomas Henzl <thenzl@redhat.com>
To: linux-scsi@vger.kernel.org
Cc: don.brace@pmcs.com, Elliott@hp.com, brace77070@gmail.com
Subject: [PATCH] hpsa: fix potential resource leak
Date: Fri, 7 Nov 2014 13:27:56 +0100 [thread overview]
Message-ID: <1415363276-9765-1-git-send-email-thenzl@redhat.com> (raw)
We should free the cfgtable allocated a few lines above.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 1ce2b43608..7d4cef779f 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -5994,7 +5994,7 @@ static int hpsa_kdump_hard_reset_controller(struct pci_dev *pdev)
}
rc = write_driver_ver_to_cfgtable(cfgtable);
if (rc)
- goto unmap_vaddr;
+ goto unmap_cfgtable;
/* If reset via doorbell register is supported, use that.
* There are two such methods. Favor the newest method.
--
1.9.3
next reply other threads:[~2014-11-07 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 12:27 Tomas Henzl [this message]
2014-11-07 12:49 ` [PATCH] hpsa: fix potential resource leak Tomas Henzl
2014-11-10 14:17 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-11-07 11:00 Tomas Henzl
2012-12-03 12:13 Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415363276-9765-1-git-send-email-thenzl@redhat.com \
--to=thenzl@redhat.com \
--cc=Elliott@hp.com \
--cc=brace77070@gmail.com \
--cc=don.brace@pmcs.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).