From: Ewan Milne <emilne@redhat.com>
To: dgilbert@interlog.com
Cc: SCSI development list <linux-scsi@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] scsi_debug: fix compare and write errors
Date: Thu, 04 Dec 2014 11:43:42 -0500 [thread overview]
Message-ID: <1417711422.3154.245.camel@localhost.localdomain> (raw)
In-Reply-To: <547611A9.2040208@interlog.com>
On Wed, 2014-11-26 at 12:45 -0500, Douglas Gilbert wrote:
> From: Douglas Gilbert <dgilbert@interlog.com>
> Date: Wed, 26 Nov 2014 12:33:48 -0500
> Subject: [PATCH] scsi_debug fix compare and write errors
>
> Kernel build tools pointed out a memory leak so that has been
> fixed and its error paths strengthened with a goto. Testing
> showed compare and write was only working for lba=0; correcting
> the length of the LBA field fixed that.
> ---
> drivers/scsi/scsi_debug.c | 31 ++++++++++++++++---------------
> 1 file changed, 16 insertions(+), 15 deletions(-)
>
> Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
Looks fine to me.
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
next prev parent reply other threads:[~2014-12-04 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 17:45 [PATCH] scsi_debug: fix compare and write errors Douglas Gilbert
2014-12-03 9:30 ` Christoph Hellwig
2014-12-04 16:43 ` Ewan Milne [this message]
2014-12-15 13:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417711422.3154.245.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=dgilbert@interlog.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox