* [PATCH 3/3] [SCSI] mpt2sas: Remove unnecessary use of a boolean variable
@ 2014-12-19 11:13 Quentin Lambert
2014-12-19 12:26 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Quentin Lambert @ 2014-12-19 11:13 UTC (permalink / raw)
To: Nagalakshmi Nandigama, Praveen Krishnamoorthy, Sreekanth Reddy,
Abhijit Mahajan, James E.J. Bottomley
Cc: MPT-FusionLinux.pdl, linux-scsi, kernel-janitors, linux-kernel
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/scsi/mpt2sas/mpt2sas_base.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
index 58e4521..c31de9d 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_base.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_base.c
@@ -1414,12 +1414,8 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc)
struct msix_entry *entries, *a;
int r;
int i;
- u8 try_msix = 0;
- if (msix_disable == -1 || msix_disable == 0)
- try_msix = 1;
-
- if (!try_msix)
+ if (msix_disable != -1 || msix_disable != 0)
goto try_ioapic;
if (_base_check_enable_msix(ioc) != 0)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] [SCSI] mpt2sas: Remove unnecessary use of a boolean variable
2014-12-19 11:13 [PATCH 3/3] [SCSI] mpt2sas: Remove unnecessary use of a boolean variable Quentin Lambert
@ 2014-12-19 12:26 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2014-12-19 12:26 UTC (permalink / raw)
To: Quentin Lambert
Cc: Nagalakshmi Nandigama, Praveen Krishnamoorthy, Sreekanth Reddy,
Abhijit Mahajan, James E.J. Bottomley, MPT-FusionLinux.pdl,
linux-scsi, kernel-janitors, linux-kernel
On Fri, 2014-12-19 at 12:13 +0100, Quentin Lambert wrote:
[]
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
[]
> @@ -1414,12 +1414,8 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc)
> struct msix_entry *entries, *a;
> int r;
> int i;
> - u8 try_msix = 0;
>
> - if (msix_disable == -1 || msix_disable == 0)
> - try_msix = 1;
> -
> - if (!try_msix)
> + if (msix_disable != -1 || msix_disable != 0)
> goto try_ioapic;
logic not the same.
Now needs && not ||
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-19 12:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-19 11:13 [PATCH 3/3] [SCSI] mpt2sas: Remove unnecessary use of a boolean variable Quentin Lambert
2014-12-19 12:26 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).