From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Smart Subject: [PATCH] lpfc: correct device removal deadlock after link bounce Date: Tue, 30 Dec 2014 12:08:58 -0500 Message-ID: <1419959338.1683.1.camel@myfc17> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from cmexedge2.emulex.com ([138.239.224.100]:3262 "EHLO CMEXEDGE2.ext.emulex.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751374AbaL3RJe (ORCPT ); Tue, 30 Dec 2014 12:09:34 -0500 Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: linux-scsi@vger.kernel.org This patch, applicable to 8G/4G/2G adapters, adds a call that resumes transmit operations after a link bounce. Without it, targets that tried to suspend exchanges after a link bounce (such as tape devices using sequence level error recovery) would never resume io operation, causing scan failures, and eventually deadlocks if a device removal request is made. The patches were cut against Christoph's scsi-queue.git, branch "drivers-for-3.18". The driver rev cut against is 10.4.8000.0 -- james s Signed-off-by: James Smart Signed-off-by: Dick Kennedy --- lpfc_els.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff -upNr a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c --- a/drivers/scsi/lpfc/lpfc_els.c 2014-12-29 12:48:08.000000000 -0500 +++ b/drivers/scsi/lpfc/lpfc_els.c 2014-12-30 11:23:04.344426606 -0500 @@ -2225,6 +2225,15 @@ lpfc_adisc_done(struct lpfc_vport *vport if ((phba->sli3_options & LPFC_SLI3_NPIV_ENABLED) && !(vport->fc_flag & FC_RSCN_MODE) && (phba->sli_rev < LPFC_SLI_REV4)) { + /* The ADISCs are complete. Doesn't matter if they + * succeeded or failed because the ADISC completion + * routine guarantees to call the state machine and + * the RPI is either unregistered (failed ADISC response) + * or the RPI is still valid and the node is marked + * mapped for a target. The exchanges should be in the + * correct state. This code is specific to SLI3. + */ + lpfc_issue_clear_la(phba, vport); lpfc_issue_reg_vpi(phba, vport); return; }