From: Hannes Reinecke <hare@suse.de>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, Daniel Wagner <dwagner@suse.de>,
Himanshu Madhani <himanshu.madhani@oracle.com>,
Nilesh Javali <njavali@marvell.com>,
Quinn Tran <qutran@marvell.com>, Martin Wilck <mwilck@suse.com>,
Roman Bolshakov <r.bolshakov@yadro.com>
Subject: Re: [PATCH v5 10/11] qla2xxx: Fix endianness annotations in header files
Date: Thu, 7 May 2020 10:31:06 +0200 [thread overview]
Message-ID: <141e8525-f7bf-97b9-dfca-e938ab17d002@suse.de> (raw)
In-Reply-To: <20200507042835.9135-11-bvanassche@acm.org>
On 5/7/20 6:28 AM, Bart Van Assche wrote:
> Annotate members of FC protocol and firmware dump data structures as big
> endian. Annotate members of RISC control structures as little endian.
> Annotate mailbox registers as little endian. Annotate the mb[] arrays as
> CPU-endian because communication of the mb[] values with the hardware
> happens through the readw() and writew() functions. readw() converts from
> __le16 to u16 and writew() converts from u16 to __le16.
>
> Reviewed-by: Daniel Wagner <dwagner@suse.de>
> Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
> Cc: Nilesh Javali <njavali@marvell.com>
> Cc: Quinn Tran <qutran@marvell.com>
> Cc: Martin Wilck <mwilck@suse.com>
> Cc: Roman Bolshakov <r.bolshakov@yadro.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/qla2xxx/qla_dbg.h | 444 +++++++++---------
> drivers/scsi/qla2xxx/qla_def.h | 646 +++++++++++++-------------
> drivers/scsi/qla2xxx/qla_fw.h | 738 +++++++++++++++---------------
> drivers/scsi/qla2xxx/qla_inline.h | 2 +-
> drivers/scsi/qla2xxx/qla_mr.h | 8 +-
> drivers/scsi/qla2xxx/qla_nvme.h | 46 +-
> drivers/scsi/qla2xxx/qla_nx.h | 36 +-
> drivers/scsi/qla2xxx/qla_target.h | 208 ++++-----
> 8 files changed, 1064 insertions(+), 1064 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2020-05-07 8:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 4:28 [PATCH v5 00/11] Fix qla2xxx endianness annotations Bart Van Assche
2020-05-07 4:28 ` [PATCH v5 01/11] qla2xxx: Fix spelling of a variable name Bart Van Assche
2020-05-07 4:28 ` [PATCH v5 02/11] qla2xxx: Suppress two recently introduced compiler warnings Bart Van Assche
2020-05-07 19:17 ` kbuild test robot
2020-05-07 22:00 ` Nick Desaulniers
2020-05-07 23:16 ` Bart Van Assche
2020-05-08 21:25 ` Arnd Bergmann
2020-05-08 22:29 ` Bart Van Assche
2020-05-09 7:59 ` Arnd Bergmann
2020-05-07 4:28 ` [PATCH v5 03/11] qla2xxx: Sort BUILD_BUG_ON() statements alphabetically Bart Van Assche
2020-05-07 4:28 ` [PATCH v5 04/11] qla2xxx: Add more BUILD_BUG_ON() statements Bart Van Assche
2020-05-07 4:28 ` [PATCH v5 05/11] qla2xxx: Make a gap in struct qla2xxx_offld_chain explicit Bart Van Assche
2020-05-07 4:28 ` [PATCH v5 06/11] qla2xxx: Increase the size of struct qla_fcp_prio_cfg to FCP_PRIO_CFG_SIZE Bart Van Assche
2020-05-07 4:28 ` [PATCH v5 07/11] qla2xxx: Change two hardcoded constants into offsetof() / sizeof() expressions Bart Van Assche
2020-05-07 4:28 ` [PATCH v5 08/11] qla2xxx: Fix the code that reads from mailbox registers Bart Van Assche
2020-05-07 4:28 ` [PATCH v5 09/11] qla2xxx: Change {RD,WRT}_REG_*() function names from upper case into lower case Bart Van Assche
2020-05-07 8:30 ` Hannes Reinecke
2020-05-07 4:28 ` [PATCH v5 10/11] qla2xxx: Fix endianness annotations in header files Bart Van Assche
2020-05-07 8:31 ` Hannes Reinecke [this message]
2020-05-07 4:28 ` [PATCH v5 11/11] qla2xxx: Fix endianness annotations in source files Bart Van Assche
2020-05-07 9:05 ` Hannes Reinecke
2020-05-07 17:27 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141e8525-f7bf-97b9-dfca-e938ab17d002@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=dwagner@suse.de \
--cc=himanshu.madhani@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mwilck@suse.com \
--cc=njavali@marvell.com \
--cc=qutran@marvell.com \
--cc=r.bolshakov@yadro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox