Re: [PATCH V6 0/3] scsi: Configure number of LUs reported by 'report-luns'

Ewan Milne
2015-01-05T14:59:53Z

On Tue, 2014-12-16 at 11:01 -0500, Rob Evers wrote:
> This patch set retrieves the number of LUs available on a target
> using the report-luns command by re-sizing the returned data
> buffer and retrying report luns.
>
> A minor bug fix is included.
>
> scsi_mod parameter max_report_luns is no longer used and is removed.
>
> Changes from previous posting:
>
> - remove exteraneous else
>
> - remove INITIAL_MAX_REPORT_LUNS, hardwire buffer sizing, and touch up
> related comment
>
> Rob Evers (3):
> scsi: Avoid unnecessary GFP_ATOMIC allocation in scsi_report_lun_scan
> scsi: Use set/get_unaligned_be32 in report_luns
> scsi: retry report-luns when reported LU count requres more memory
>
> drivers/scsi/scsi_scan.c | 54 ++++++++++++++----------------------------------
> 1 file changed, 15 insertions(+), 39 deletions(-)
>

Looks good.

Reviewed-by: Ewan D. Milne <emilne@redhat.com>