From: Ewan Milne <emilne@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>,
James Bottomley <JBottomley@Parallels.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/4] scsi: annotate sdev_prefix_printk and scmd_printk as printf-like
Date: Mon, 19 Jan 2015 10:32:42 -0500 [thread overview]
Message-ID: <1421681562.3891.216.camel@localhost.localdomain> (raw)
In-Reply-To: <1421593891-19984-2-git-send-email-hch@lst.de>
On Sun, 2015-01-18 at 16:11 +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> include/scsi/scsi_device.h | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
> index d1aad4d..2e0281e 100644
> --- a/include/scsi/scsi_device.h
> +++ b/include/scsi/scsi_device.h
> @@ -237,14 +237,15 @@ struct scsi_dh_data {
> * like scmd_printk, but the device name is passed in
> * as a string pointer
> */
> -extern int sdev_prefix_printk(const char *, const struct scsi_device *,
> - const char *, const char *, ...);
> +__printf(4, 5) int
> +sdev_prefix_printk(const char *, const struct scsi_device *, const char *,
> + const char *, ...);
>
> #define sdev_printk(l, sdev, fmt, a...) \
> sdev_prefix_printk(l, sdev, NULL, fmt, ##a)
>
> -extern int scmd_printk(const char *, const struct scsi_cmnd *,
> - const char *, ...);
> +__printf(3, 4) int
> +scmd_printk(const char *, const struct scsi_cmnd *, const char *, ...);
>
> #define scmd_dbg(scmd, fmt, a...) \
> do { \
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
next prev parent reply other threads:[~2015-01-19 15:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 15:11 [PATCH 1/4] scsi: always use format argumets for dev_printk Christoph Hellwig
2015-01-18 15:11 ` [PATCH 2/4] scsi: annotate sdev_prefix_printk and scmd_printk as printf-like Christoph Hellwig
2015-01-19 7:04 ` Hannes Reinecke
2015-01-19 15:32 ` Ewan Milne [this message]
2015-01-18 15:11 ` [PATCH 3/4] ch: remove debug noise in ch_do_scsi Christoph Hellwig
2015-01-19 7:05 ` Hannes Reinecke
2015-01-19 15:32 ` Ewan Milne
2015-01-18 15:11 ` [PATCH 4/4] sr: reduce debug noise in sr_do_ioctl Christoph Hellwig
2015-01-19 7:05 ` Hannes Reinecke
2015-01-19 15:33 ` Ewan Milne
2015-01-18 15:22 ` [PATCH 1/4] scsi: always use format argumets for dev_printk James Bottomley
2015-01-19 7:04 ` Hannes Reinecke
2015-01-19 15:32 ` Ewan Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421681562.3891.216.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=JBottomley@Parallels.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox