From: Mike Snitzer <snitzer@redhat.com>
To: Jens Axboe <axboe@kernel.dk>, Keith Busch <keith.busch@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
dm-devel@redhat.com
Subject: [PATCH 0/7] dm: add full blk-mq support to request-based DM
Date: Wed, 11 Mar 2015 23:56:35 -0400 [thread overview]
Message-ID: <1426132602-34331-1-git-send-email-snitzer@redhat.com> (raw)
This patchset updates request-based DM (used exclussively by DM
multipath) to support blk-mq I/O path or the old ->request_fn I/O
path -- the default is still the old ->request_fn I/O path.
Like was done for SCSI, I've exposed a dm-mod.ko 'use_blk_mq' module
parameter and a CONFIG_DM_MQ_DEFAULT. I've queued these patches in
linux-next via linux-dm.git's 'for-next' branch -- my goal is for
these changes to land upstream in 4.1.
I've tested all 4 supported permutations of rq-based queue stacking:
1) blk-mq mpath stacked on blk-mq device(s)
2) blk-mq mpath stacked on ->request_fn device(s)
3) old ->request_fn mpath stacked on blk-mq device(s)
4) old ->request_fn mpath stacked on old ->request_fn device(s)
There is definitely much more room for optimizing the blk-mq mpath
queue (via dm_mq_ops setup) to have more awareness about the
characteristics of the underlying blk-mq device(s) -- Jens offered
some suggestions that are worth pursuing. Goal being to leverage the
ability to have multiple software submission queues that map to the
underlying paths' HW queue. I expect Keith to be the most likely
person to pursue these follow-on optimizations given his immediate
access to NVMe devices, etc.
blk-mq allows for the removal of 2 of the 3 mempools and associated
allocations that were traditionally performed using old ->request_fn
I/O path. The md->bs bioset still remains for cloning a request's
bios.
I'll be pursuing the possibility of removing the bio cloning that
happens when cloning a request (it was put in place for partial
completion of a request's bios but the prospect of avoiding those bio
clones warrants further review of how useful those partial completions
are, see: http://www.redhat.com/archives/dm-devel/2014-June/msg00030.html)
Jens and Keith, special thanks for your help answering more blk-mq
questions than I'd have hoped would be needed while at LSF/MM.
Keith Busch (1):
blk-mq: don't wait in blk_mq_queue_enter() if __GFP_WAIT isn't set
Mike Snitzer (6):
blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path
blk-mq: add blk_mq_init_allocated_queue and export blk_mq_register_disk
blk-mq: export blk_mq_run_hw_queues
dm: add full blk-mq support to request-based DM
dm: optimize dm_mq_queue_rq to _not_ use kthread if using pure blk-mq
dm: add 'use_blk_mq' module param and expose in per-device ro sysfs attr
block/blk-mq-sysfs.c | 1 +
block/blk-mq.c | 47 ++++--
drivers/md/Kconfig | 11 ++
drivers/md/dm-mpath.c | 4 +-
drivers/md/dm-sysfs.c | 9 ++
drivers/md/dm-table.c | 17 +-
drivers/md/dm.c | 414 +++++++++++++++++++++++++++++++++++++++----------
drivers/md/dm.h | 5 +-
include/linux/blk-mq.h | 3 +
9 files changed, 401 insertions(+), 110 deletions(-)
--
1.9.5 (Apple Git-50.3)
next reply other threads:[~2015-03-12 3:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 3:56 Mike Snitzer [this message]
2015-03-12 3:56 ` [PATCH 1/7] blk-mq: fix use of incorrect goto label in blk_mq_init_queue error path Mike Snitzer
2015-03-12 7:48 ` Ming Lei
2015-03-12 13:51 ` Mike Snitzer
2015-03-13 3:29 ` Mike Snitzer
2015-03-12 14:27 ` [PATCH 1/7 v2] " Mike Snitzer
2015-03-13 3:53 ` [PATCH 1/7 v3] " Mike Snitzer
2015-03-12 3:56 ` [PATCH 2/7] blk-mq: add blk_mq_init_allocated_queue and export blk_mq_register_disk Mike Snitzer
2015-03-12 8:10 ` Ming Lei
2015-03-12 14:29 ` [PATCH 2/7 v2] " Mike Snitzer
2015-03-13 3:56 ` [PATCH 2/7 v3] " Mike Snitzer
2015-03-12 3:56 ` [PATCH 3/7] blk-mq: export blk_mq_run_hw_queues Mike Snitzer
2015-03-12 3:56 ` [PATCH 4/7] blk-mq: don't wait in blk_mq_queue_enter() if __GFP_WAIT isn't set Mike Snitzer
2015-03-12 3:56 ` [PATCH 5/7] dm: add full blk-mq support to request-based DM Mike Snitzer
2015-03-12 3:56 ` [PATCH 6/7] dm: optimize dm_mq_queue_rq to _not_ use kthread if using pure blk-mq Mike Snitzer
2015-03-12 3:56 ` [PATCH 7/7] dm: add 'use_blk_mq' module param and expose in per-device ro sysfs attr Mike Snitzer
2015-03-13 14:34 ` [PATCH 0/7] dm: add full blk-mq support to request-based DM Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426132602-34331-1-git-send-email-snitzer@redhat.com \
--to=snitzer@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).