From: "Nicholas A. Bellinger" <nab@daterainc.com>
To: target-devel <target-devel@vger.kernel.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Sagi Grimberg <sagig@mellanox.com>,
Slava Shwartsman <valyushash@gmail.com>,
Nicholas Bellinger <nab@linux-iscsi.org>
Subject: [PATCH 0/3] iscsi/iser-target: Convert to kthread.h + fix logout failure
Date: Sat, 21 Mar 2015 06:16:01 +0000 [thread overview]
Message-ID: <1426918564-22581-1-git-send-email-nab@daterainc.com> (raw)
From: Nicholas Bellinger <nab@linux-iscsi.org>
Hello Sagi & Slava,
Following the earlier pre-LSF discussion, here is a patch series
to convert iscsi/iser target to using modern kthread.h primitives
when starting / stopping RX + TX kernel threads during iscsi_conn
creation / shutdown.
So far this code has been tested with traditional iscsi-target
login / logout code-paths, and needs to be verified via iser-target
login / logout code-paths as well.
Also, patch #3 is a seperate iser-target bugfix to handle a failed
outgoing ISCSI_OP_LOGOUT_RSP in isert_cq_comp_err() completion
interrupt path code. This one may or may not have been triggering
earlier, but addresses a possible iser-target specific logout bug.
Please review + test for v4.1-rc1 code.
Thank you,
--nab
Nicholas Bellinger (3):
iscsi-target: Convert iscsi_thread_set usage to kthread.h
iscsi-target: Drop legacy iscsi_target_tq.c logic
iser-target: Handle special case for logout during connection failure
drivers/infiniband/ulp/isert/ib_isert.c | 16 +-
drivers/target/iscsi/Makefile | 1 -
drivers/target/iscsi/iscsi_target.c | 109 +++----
drivers/target/iscsi/iscsi_target_erl0.c | 14 +-
drivers/target/iscsi/iscsi_target_login.c | 60 +++-
drivers/target/iscsi/iscsi_target_tq.c | 495 ------------------------------
drivers/target/iscsi/iscsi_target_tq.h | 84 -----
drivers/target/iscsi/iscsi_target_util.c | 1 -
include/target/iscsi/iscsi_target_core.h | 13 +-
9 files changed, 131 insertions(+), 662 deletions(-)
delete mode 100644 drivers/target/iscsi/iscsi_target_tq.c
delete mode 100644 drivers/target/iscsi/iscsi_target_tq.h
--
1.9.1
next reply other threads:[~2015-03-21 6:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 6:16 Nicholas A. Bellinger [this message]
2015-03-21 6:16 ` [PATCH 1/3] iscsi-target: Convert iscsi_thread_set usage to kthread.h Nicholas A. Bellinger
2015-03-23 12:21 ` Sagi Grimberg
2015-03-24 16:37 ` Sagi Grimberg
2015-03-26 6:45 ` Nicholas A. Bellinger
2015-03-21 6:16 ` [PATCH 2/3] iscsi-target: Drop legacy iscsi_target_tq.c logic Nicholas A. Bellinger
2015-03-21 6:16 ` [PATCH 3/3] iser-target: Handle special case for logout during connection failure Nicholas A. Bellinger
2015-03-22 16:06 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426918564-22581-1-git-send-email-nab@daterainc.com \
--to=nab@daterainc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
--cc=valyushash@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox