linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: axboe@kernel.dk, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org
Cc: hch@lst.de, Jens Axboe <axboe@fb.com>
Subject: [PATCH 2/6] scsi: ensure that a request is valid when returning it from scsi_find_tag()
Date: Tue, 7 Apr 2015 11:18:36 -0600	[thread overview]
Message-ID: <1428427120-20971-3-git-send-email-axboe@fb.com> (raw)
In-Reply-To: <1428427120-20971-1-git-send-email-axboe@fb.com>

For the scsi-mq case, ensure that the request has been started before
returning it from scsi_find_tag(). This is akin to the ->special
check for the non-mq case, it ensures that the request has been setup
and issued.

Signed-off-by: Jens Axboe <axboe@fb.com>
---
 include/scsi/scsi_tcq.h | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h
index b27977e8aaed..8634cab61aeb 100644
--- a/include/scsi/scsi_tcq.h
+++ b/include/scsi/scsi_tcq.h
@@ -35,8 +35,15 @@ static inline struct scsi_cmnd *scsi_find_tag(struct scsi_device *sdev, int tag)
         struct request *req;
 
         if (tag != SCSI_NO_TAG) {
-		if (shost_use_blk_mq(sdev->host))
-			return scsi_mq_find_tag(sdev->host, tag);
+		if (shost_use_blk_mq(sdev->host)) {
+			struct scsi_cmnd *scmd;
+
+			scmd = scsi_mq_find_tag(sdev->host, tag);
+			if (blk_mq_request_started(scmd->request))
+				return scmd;
+
+			return NULL;
+		}
 
 		req = blk_queue_find_tag(sdev->request_queue, tag);
 	        return req ? (struct scsi_cmnd *)req->special : NULL;
-- 
1.9.1

  parent reply	other threads:[~2015-04-07 17:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 17:18 [PATCH RFC v2] mpt2/mpt3sas lock reduction for scsi-mq Jens Axboe
2015-04-07 17:18 ` [PATCH 1/6] scsi: add host template init/exit_command hooks Jens Axboe
2015-04-07 17:18 ` Jens Axboe [this message]
2015-04-13  9:47   ` [PATCH 2/6] scsi: ensure that a request is valid when returning it from scsi_find_tag() Christoph Hellwig
2015-04-07 17:18 ` [PATCH 3/6] mpt2sas: get rid of MPI2_FUNCTION_SCSI_TASK_MGMT Jens Axboe
2015-04-13  9:49   ` Christoph Hellwig
2015-04-07 17:18 ` [PATCH 4/6] mpt2sas: store scsi io tracker data in the scsi request Jens Axboe
2015-04-13  9:49   ` Christoph Hellwig
2015-04-07 17:18 ` [PATCH 5/6] mpt3sas: get rid of MPI2_FUNCTION_SCSI_TASK_MGMT Jens Axboe
2015-04-07 17:18 ` [PATCH 6/6] mpt3sas: store scsi io tracker data in the scsi request Jens Axboe
2015-04-13  9:50 ` [PATCH RFC v2] mpt2/mpt3sas lock reduction for scsi-mq Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428427120-20971-3-git-send-email-axboe@fb.com \
    --to=axboe@fb.com \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).