From: Himanshu Madhani <himanshu.madhani@qlogic.com>
To: jbottomley@parallels.com
Cc: hch@lst.de, giridhar.malavali@qlogic.com,
himanshu.madhani@qlogic.com, andrew.vasquez@qlogic.com,
linux-scsi@vger.kernel.org
Subject: [PATCH 11/14] qla2xxx: Prevent multiple firmware dump collection for ISP27XX.
Date: Thu, 9 Apr 2015 15:00:05 -0400 [thread overview]
Message-ID: <1428606008-14976-12-git-send-email-himanshu.madhani@qlogic.com> (raw)
In-Reply-To: <1428606008-14976-1-git-send-email-himanshu.madhani@qlogic.com>
For ISP27XX, driver will capture new firmware dump even if there is
one already collected. Prevent this from happening by checking
fw_dumped flag.
Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
Signed-off-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
---
drivers/scsi/qla2xxx/qla_dbg.c | 2 +-
drivers/scsi/qla2xxx/qla_tmpl.c | 4 ++++
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c
index b06b6b5..0e6ee3c 100644
--- a/drivers/scsi/qla2xxx/qla_dbg.c
+++ b/drivers/scsi/qla2xxx/qla_dbg.c
@@ -60,7 +60,7 @@
* | | | 0xb13c-0xb140 |
* | | | 0xb149 |
* | MultiQ | 0xc00c | |
- * | Misc | 0xd213 | 0xd016-0xd017 |
+ * | Misc | 0xd300 | 0xd016-0xd017 |
* | | | 0xd021,0xd024 |
* | | | 0xd025,0xd029 |
* | | | 0xd02a,0xd02e |
diff --git a/drivers/scsi/qla2xxx/qla_tmpl.c b/drivers/scsi/qla2xxx/qla_tmpl.c
index 7f67fb2..58fc115 100644
--- a/drivers/scsi/qla2xxx/qla_tmpl.c
+++ b/drivers/scsi/qla2xxx/qla_tmpl.c
@@ -947,6 +947,10 @@ qla27xx_fwdump(scsi_qla_host_t *vha, int hardware_locked)
ql_log(ql_log_warn, vha, 0xd01e, "fwdump buffer missing.\n");
else if (!vha->hw->fw_dump_template)
ql_log(ql_log_warn, vha, 0xd01f, "fwdump template missing.\n");
+ else if (vha->hw->fw_dumped)
+ ql_log(ql_log_warn, vha, 0xd300,
+ "Firmware has been previously dumped (%p),"
+ " -- ignoring request\n", vha->hw->fw_dump);
else
qla27xx_execute_fwdt_template(vha);
--
1.7.7
next prev parent reply other threads:[~2015-04-09 19:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 18:59 [PATCH 00/14] qla2xxx: Patches for scsi "misc" branch Himanshu Madhani
2015-04-09 18:59 ` [PATCH 01/14] qla2xxx: Fix warnings reported by static checker Himanshu Madhani
2015-04-10 6:30 ` Hannes Reinecke
2015-04-09 18:59 ` [PATCH 02/14] qla2xxx: Fix crash due to wrong casting of reg for ISP27XX Himanshu Madhani
2015-04-10 5:59 ` Bart Van Assche
2015-04-10 6:31 ` Hannes Reinecke
2015-04-09 18:59 ` [PATCH 03/14] qla2xxx: Increase the wait time for firmware to be ready for P3P Himanshu Madhani
2015-04-10 6:31 ` Hannes Reinecke
2015-04-09 18:59 ` [PATCH 04/14] qla2xxx: Fix beacon blink for ISP27XX Himanshu Madhani
2015-04-10 6:32 ` Hannes Reinecke
2015-04-09 18:59 ` [PATCH 05/14] qla2xxx: Add support to load firmware from file for ISP 26XX/27XX Himanshu Madhani
2015-04-10 6:33 ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 06/14] qla2xxx: Add message for sucessful FW dump collected for ISP27XX Himanshu Madhani
2015-04-10 6:33 ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 07/14] qla2xxx: Add udev notification to save fw dump " Himanshu Madhani
2015-04-10 6:35 ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 08/14] qla2xxx: Add serdes read/write support " Himanshu Madhani
2015-04-10 6:35 ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 09/14] qla2xxx: Add debugging info for MBX timeout Himanshu Madhani
2015-04-10 6:36 ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 10/14] qla2xxx: Disable Interrupt handshake for ISP27XX Himanshu Madhani
2015-04-10 6:37 ` Hannes Reinecke
2015-04-09 19:00 ` Himanshu Madhani [this message]
2015-04-10 6:37 ` [PATCH 11/14] qla2xxx: Prevent multiple firmware dump collection " Hannes Reinecke
2015-04-09 19:00 ` [PATCH 12/14] qla2xxx: Fix virtual port configuration, when switch port is disabled/enabled Himanshu Madhani
2015-04-10 6:38 ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 13/14] qla2xxx: Restore physical port WWPN only, when port down detected for FA-WWPN port Himanshu Madhani
2015-04-10 6:39 ` Hannes Reinecke
2015-04-09 19:00 ` [PATCH 14/14] qla2xxx: Update driver version to 8.07.00.18-k Himanshu Madhani
2015-04-10 6:39 ` Hannes Reinecke
2015-04-10 5:53 ` [PATCH 00/14] qla2xxx: Patches for scsi "misc" branch Bart Van Assche
2015-04-10 15:46 ` James Bottomley
2015-04-10 18:46 ` Himanshu Madhani
2015-06-02 19:52 ` Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428606008-14976-12-git-send-email-himanshu.madhani@qlogic.com \
--to=himanshu.madhani@qlogic.com \
--cc=andrew.vasquez@qlogic.com \
--cc=giridhar.malavali@qlogic.com \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).