public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <jbottomley@parallels.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Ondrey Zary <linux@rainbow-software.org>,
	Doug Gilberg <dgilbert@interlog.com>,
	linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 21/22] advansys: use spin_lock_irqsave() in interrupt handler
Date: Fri, 24 Apr 2015 10:32:56 +0200	[thread overview]
Message-ID: <1429864377-67002-22-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1429864377-67002-1-git-send-email-hare@suse.de>

We should be using spin_lock_irqsave() when within the
interrupt handler.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/scsi/advansys.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 2c9f9e9..2c4efb4 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -7242,9 +7242,10 @@ static irqreturn_t advansys_interrupt(int irq, void *dev_id)
 	struct Scsi_Host *shost = dev_id;
 	struct asc_board *boardp = shost_priv(shost);
 	irqreturn_t result = IRQ_NONE;
+	unsigned long flags;
 
 	ASC_DBG(2, "boardp 0x%p\n", boardp);
-	spin_lock(shost->host_lock);
+	spin_lock_irqsave(shost->host_lock, flags);
 	if (ASC_NARROW_BOARD(boardp)) {
 		if (AscIsIntPending(shost->io_port)) {
 			result = IRQ_HANDLED;
@@ -7259,7 +7260,7 @@ static irqreturn_t advansys_interrupt(int irq, void *dev_id)
 			ASC_STATS(shost, interrupt);
 		}
 	}
-	spin_unlock(shost->host_lock);
+	spin_unlock_irqrestore(shost->host_lock, flags);
 
 	ASC_DBG(1, "end\n");
 	return result;
-- 
1.8.5.2


  parent reply	other threads:[~2015-04-24  8:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24  8:32 [PATCHv2 00/22] Nobody loves the advansys driver Hannes Reinecke
2015-04-24  8:32 ` [PATCH 01/22] advansys: use host_reset Hannes Reinecke
2015-04-24  8:32 ` [PATCH 02/22] advansys: use shared host tag map for command lookup Hannes Reinecke
2015-04-24  8:32 ` [PATCH 03/22] advansys: use DMA-API for mapping sense buffer Hannes Reinecke
2015-04-24  8:32 ` [PATCH 04/22] advansys: Use DMA-API for carrier buffer Hannes Reinecke
2015-04-24  8:32 ` [PATCH 05/22] advansys: Use DMA-API for mapping request blocks Hannes Reinecke
2015-04-24  8:32 ` [PATCH 06/22] advansys: Use dma_pool for sg elements Hannes Reinecke
2015-04-24  8:32 ` [PATCH 07/22] advansys: use 'bool' instead of 'int' Hannes Reinecke
2015-04-24  8:32 ` [PATCH 08/22] advansys: use standard data types Hannes Reinecke
2015-04-24  8:32 ` [PATCH 09/22] advansys: Remove 'TRUE' and 'FALSE' definitions Hannes Reinecke
2015-04-24  8:32 ` [PATCH 10/22] advansys: remove 'ERR' definition Hannes Reinecke
2015-04-24  8:32 ` [PATCH 11/22] advansys: Make AscIsrChipHalted() a void function Hannes Reinecke
2015-04-24  8:32 ` [PATCH 12/22] advansys: cleanup function return codes Hannes Reinecke
2015-04-24  8:32 ` [PATCH 13/22] advansys: scsi_q1->data_addr is little endian Hannes Reinecke
2015-04-24  8:32 ` [PATCH 14/22] advansys: Remove ASC_SCSI_REQ_Q Hannes Reinecke
2015-04-24  8:32 ` [PATCH 15/22] advansys: Remove CC_VERY_LONG_SG_LIST Hannes Reinecke
2015-04-24  8:32 ` [PATCH 16/22] advansys: rename 'ASC_RQ_XX' to 'ADV_RQ_XX' Hannes Reinecke
2015-04-24  8:32 ` [PATCH 17/22] advansys: Remove 'a_flag' Hannes Reinecke
2015-04-24  8:32 ` [PATCH 18/22] advansys: Remove obsolete virtual memory mapping comment Hannes Reinecke
2015-04-24  8:32 ` [PATCH 19/22] advansys: Remove comment around cmd_per_lun Hannes Reinecke
2015-04-24  9:41   ` Christoph Hellwig
2015-04-24  9:47     ` Hannes Reinecke
2015-04-24  8:32 ` [PATCH 20/22] advansys: Check for DMA mapping errors Hannes Reinecke
2015-04-24  8:32 ` Hannes Reinecke [this message]
2015-04-24  8:32 ` [PATCH 22/22] advansys: Update to version 3.5 and remove compilation warning Hannes Reinecke
2015-04-24  9:42   ` Christoph Hellwig
2015-04-24  9:47     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429864377-67002-22-git-send-email-hare@suse.de \
    --to=hare@suse.de \
    --cc=dgilbert@interlog.com \
    --cc=hch@lst.de \
    --cc=jbottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux@rainbow-software.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox