From: Paul Bolle <pebolle@tiscali.nl>
To: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: JBottomley@odin.com, linux@arm.linux.org.uk,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/scsi/arm/acornscsi.c: rename CONFIG_ACORNSCSI_CONSTANTS
Date: Tue, 28 Apr 2015 21:10:24 +0200 [thread overview]
Message-ID: <1430248224.2411.68.camel@x220> (raw)
In-Reply-To: <1430230511-10869-1-git-send-email-valentinrothberg@gmail.com>
On Tue, 2015-04-28 at 16:15 +0200, Valentin Rothberg wrote:
> CONFIG_ACORNSCSI_CONSTANTS is a file local CPP identifier and thereby
> violates the naming convention of Kconfig options in Make and CPP
> syntax; only Kconfig options should carry the 'CONFIG_' prefix.
>
> This patch removes the 'CONFIG_' prefix to apply to this convention and
> to make static analysis tools happy.
Will the Erlangen bot still spot ACORNSCSI_CONSTANTS as a potential
issue?
Paul Bolle
next prev parent reply other threads:[~2015-04-28 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 14:15 [PATCH] drivers/scsi/arm/acornscsi.c: rename CONFIG_ACORNSCSI_CONSTANTS Valentin Rothberg
2015-04-28 19:10 ` Paul Bolle [this message]
2015-04-28 19:26 ` Valentin Rothberg
2015-04-28 19:34 ` Paul Bolle
2015-04-28 19:57 ` Valentin Rothberg
2015-05-06 10:38 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430248224.2411.68.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=JBottomley@odin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox