linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: linux-scsi@vger.kernel.org
Cc: Hannes Reinecke <hare@suse.de>, Mike Snitzer <snitzer@redhat.com>,
	Mike Christie <michaelc@cs.wisc.edu>,
	"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: [PATCH 1/9] dm-mpath: check kstrdup return value in parse_hw_handler
Date: Thu, 30 Apr 2015 19:32:23 +0200	[thread overview]
Message-ID: <1430415151-30948-2-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1430415151-30948-1-git-send-email-hch@lst.de>

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 drivers/md/dm-mpath.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 6395347..01e5f8e 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -732,6 +732,9 @@ static int parse_hw_handler(struct dm_arg_set *as, struct multipath *m)
 		return 0;
 
 	m->hw_handler_name = kstrdup(dm_shift_arg(as), GFP_KERNEL);
+	if (!m->hw_handler_name)
+		return -ENOMEM;
+
 	if (!try_then_request_module(scsi_dh_handler_exist(m->hw_handler_name),
 				     "scsi_dh_%s", m->hw_handler_name)) {
 		ti->error = "unknown hardware handler type";
-- 
1.9.1


  reply	other threads:[~2015-04-30 17:33 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 17:32 integrate scsi_dh better into the scsi core Christoph Hellwig
2015-04-30 17:32 ` Christoph Hellwig [this message]
2015-04-30 18:35   ` [PATCH 1/9] dm-mpath: check kstrdup return value in parse_hw_handler Hannes Reinecke
2015-05-01 13:57   ` Mike Snitzer
2015-05-01 15:07   ` Martin K. Petersen
2015-05-01 15:29   ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 2/9] dm-mpath, scsi_dh: don't let dm detach device handlers Christoph Hellwig
2015-04-30 18:21   ` Mike Snitzer
2015-05-01  9:20     ` Christoph Hellwig
2015-05-01  7:10   ` Hannes Reinecke
2015-05-01 13:58   ` Mike Snitzer
2015-05-01 15:30   ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 3/9] dm-mpath: don't call scsi_dh_attach when we want to retain the attached handler Christoph Hellwig
2015-04-30 18:25   ` Mike Snitzer
2015-05-01  7:10   ` Hannes Reinecke
2015-05-01 15:34   ` Martin K. Petersen
2015-05-01 16:46     ` Christoph Hellwig
2015-04-30 17:32 ` [PATCH 4/9] dm-mpath, scsi_dh: request scsi_dh modules in scsi_dh, not dm-mpath Christoph Hellwig
2015-04-30 18:28   ` Mike Snitzer
2015-05-01  7:11   ` Hannes Reinecke
2015-05-01 13:59   ` Mike Snitzer
2015-05-01 15:35   ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 5/9] scsi_dh: integrate into the core SCSI code Christoph Hellwig
2015-05-01  7:13   ` Hannes Reinecke
2015-05-01 15:36   ` Martin K. Petersen
2015-05-04  7:50   ` Hannes Reinecke
2015-05-05 15:25     ` Christoph Hellwig
2015-04-30 17:32 ` [PATCH 6/9] scsi_dh: move device matching to the core code Christoph Hellwig
2015-04-30 18:32   ` Mike Snitzer
2015-05-01  7:15   ` Hannes Reinecke
2015-05-01 15:39   ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 7/9] scsi_dh: kill struct scsi_dh_data Christoph Hellwig
2015-05-01  7:17   ` Hannes Reinecke
2015-05-01 15:41   ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 8/9] scsi_dh: add a common helper to get a scsi_device from a request_queue Christoph Hellwig
2015-05-01  7:18   ` Hannes Reinecke
2015-05-01 15:45   ` Martin K. Petersen
2015-04-30 17:32 ` [PATCH 9/9] scsi_dh: don't allow to detach device handlers at runtime Christoph Hellwig
2015-05-01  7:19   ` Hannes Reinecke
2015-05-01 15:46   ` Martin K. Petersen
2015-04-30 18:31 ` integrate scsi_dh better into the scsi core Mike Snitzer
2015-05-01 15:47 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430415151-30948-2-git-send-email-hch@lst.de \
    --to=hch@lst.de \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michaelc@cs.wisc.edu \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).