Re: [PATCH 09/17] scsi_dh_alua: switch to scsi_execute()

Hannes Reinecke
2015-05-06T09:58:18Z

On 05/06/2015 11:26 AM, Christoph Hellwig wrote:
> On Mon, May 04, 2015 at 02:42:15PM +0200, Hannes Reinecke wrote:
>> All commands are issued synchronously, so no need to open-code
>> scsi_execute anymore.
>
> Currently the alua codes doesn't set REQ_PREEMPT, and uses a GFP_NOIO
> allocation. Please document why changing these is safe/and or desirable.
>
> Also it would be good to a change like this to the other device handlers,
> as the code is copy and pasted everywhere, and only hp_sw has an asynchronous
> case that can be handled separately.
>
Well, yes, of course.
However, for ALUA this will only work once the previous alua patches
are in. So I'd prefer to have another patchset on top of this,
converting the other device handlers.

As for the REQ_PREEMPT / GFP_NOIO I'll have a look and document
or fix is as appropriate.

Cheers,

Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html