Re: [PATCH 02/17] scsi_dh_alua: Disable ALUA handling for non-disk devices

Christoph Hellwig
2015-05-11T06:46:45Z

On Mon, May 04, 2015 at 02:42:08PM +0200, Hannes Reinecke wrote:
> Non-disk devices should be ignored when detecting
> ALUA capabilities.

Hmm. I don't think we should even attach the alua handler in this case,
e.g. refine the check in scsi_dh_find_driver. But then again I don't
remember how the spec wording actually disallows this, and a quick grep
of SPC-4 can't find anything either. Can you put a reference to the spec
section that disallows attachment to non-disk devices into the code?

> + if (sdev->type != TYPE_DISK &&
> + sdev->type != TYPE_RBC &&
> + sdev->type != TYPE_OSD) {

And does it really allow RBC (but not ZBC)?