Re: [PATCH 07/17] scsi_dh_alua: Pass buffer as function argument

Bart Van Assche
2015-05-07T11:57:54Z

On 05/04/15 14:42, Hannes Reinecke wrote:
> - rq->cmd[6] = (h->bufflen >> 24) & 0xff;
> - rq->cmd[7] = (h->bufflen >> 16) & 0xff;
> - rq->cmd[8] = (h->bufflen >> 8) & 0xff;
> - rq->cmd[9] = h->bufflen & 0xff;
> + rq->cmd[6] = (bufflen >> 24) & 0xff;
> + rq->cmd[7] = (bufflen >> 16) & 0xff;
> + rq->cmd[8] = (bufflen >> 8) & 0xff;
> + rq->cmd[9] = bufflen & 0xff;

This would have been a good opportunity to introduce
get_unaligned_be32(). But even without that change:

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>