Re: [PATCH 01/17] scsi_dh: return individual errors in scsi_dh_activate()

Bart Van Assche
2015-05-07T11:34:38Z

On 05/04/15 14:42, Hannes Reinecke wrote:
> When calling scsi_dh_activate() we should be returning
> individual errors and not lumping all into one.
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/scsi/device_handler/scsi_dh.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh.c b/drivers/scsi/device_handler/scsi_dh.c
> index 155abeab..a4afd30 100644
> --- a/drivers/scsi/device_handler/scsi_dh.c
> +++ b/drivers/scsi/device_handler/scsi_dh.c
> @@ -315,9 +315,10 @@ int scsi_dh_activate(struct request_queue *q, activate_complete fn, void *data)
>
> if (!sdev->handler)
> goto out_fn;
> + err = SCSI_DH_NOTCONN;
> if (sdev->sdev_state == SDEV_CANCEL ||
> sdev->sdev_state == SDEV_DEL)
> - goto out_fn;
> + goto out_fn;
>
> err = SCSI_DH_DEV_OFFLINED;
> if (sdev->sdev_state == SDEV_OFFLINE)
>

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>