* [PATCH] [SCSI] libsas: Kconfig: Enable SATA compatibility by default [not found] <21826.14993.432271.52216@mariner.uk.xensource.com> @ 2015-05-01 14:36 ` Ian Jackson 2015-05-03 13:07 ` Julian Calaby 2015-05-06 14:23 ` James Bottomley 0 siblings, 2 replies; 4+ messages in thread From: Ian Jackson @ 2015-05-01 14:36 UTC (permalink / raw) To: linux-scsi, linux-kernel, xen-devel Cc: Ian Jackson, Ian Jackson, James Bottomley, Donald D Dugger, Pawel Baldysiak, Lukasz Dorau, Artur Paszkiewicz, Ian Campbell, Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel SATA controllers support SATA disks. The kernel should be able to drive these, by default. It should not silently (apart from a debugging-only printk) ignore them. Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com> CC: James Bottomley <James.Bottomley@suse.de> CC: Donald D Dugger <donald.d.dugger@intel.com> CC: Pawel Baldysiak <pawel.baldysiak@intel.com> CC: Lukasz Dorau <lukasz.dorau@intel.com> CC: Artur Paszkiewicz <artur.paszkiewicz@intel.com> CC: Ian Campbell <ian.campbell@citrix.com> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com> CC: David Vrabel <david.vrabel@citrix.com> --- drivers/scsi/libsas/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/libsas/Kconfig b/drivers/scsi/libsas/Kconfig index 9dafe64..16258b0 100644 --- a/drivers/scsi/libsas/Kconfig +++ b/drivers/scsi/libsas/Kconfig @@ -34,6 +34,7 @@ config SCSI_SAS_ATA bool "ATA support for libsas (requires libata)" depends on SCSI_SAS_LIBSAS depends on ATA = y || ATA = SCSI_SAS_LIBSAS + default y help Builds in ATA support into libsas. Will necessitate the loading of libata along with libsas. -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [SCSI] libsas: Kconfig: Enable SATA compatibility by default 2015-05-01 14:36 ` [PATCH] [SCSI] libsas: Kconfig: Enable SATA compatibility by default Ian Jackson @ 2015-05-03 13:07 ` Julian Calaby 2015-05-06 14:03 ` Ian Jackson 2015-05-06 14:23 ` James Bottomley 1 sibling, 1 reply; 4+ messages in thread From: Julian Calaby @ 2015-05-03 13:07 UTC (permalink / raw) To: Ian Jackson Cc: linux-scsi, linux-kernel@vger.kernel.org, xen-devel, James Bottomley, Donald D Dugger, Pawel Baldysiak, Lukasz Dorau, Artur Paszkiewicz, Ian Campbell, Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel Hi Ian, On Sat, May 2, 2015 at 12:36 AM, Ian Jackson <ian.jackson@eu.citrix.com> wrote: > SATA controllers support SATA disks. The kernel should be able to Do you mean SAS controllers? Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/ ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [SCSI] libsas: Kconfig: Enable SATA compatibility by default 2015-05-03 13:07 ` Julian Calaby @ 2015-05-06 14:03 ` Ian Jackson 0 siblings, 0 replies; 4+ messages in thread From: Ian Jackson @ 2015-05-06 14:03 UTC (permalink / raw) To: Julian Calaby Cc: Ian Jackson, linux-scsi, linux-kernel@vger.kernel.org, xen-devel, James Bottomley, Donald D Dugger, Pawel Baldysiak, Lukasz Dorau, Artur Paszkiewicz, Ian Campbell, Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel Julian Calaby writes ("Re: [PATCH] [SCSI] libsas: Kconfig: Enable SATA compatibility by default"): > On Sat, May 2, 2015 at 12:36 AM, Ian Jackson <ian.jackson@eu.citrix.com> wrote: > > SATA controllers support SATA disks. The kernel should be able to > > Do you mean SAS controllers? Yes, sorry. Do you want me to resubmit with a fixed commit message ? Ian. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [SCSI] libsas: Kconfig: Enable SATA compatibility by default 2015-05-01 14:36 ` [PATCH] [SCSI] libsas: Kconfig: Enable SATA compatibility by default Ian Jackson 2015-05-03 13:07 ` Julian Calaby @ 2015-05-06 14:23 ` James Bottomley 1 sibling, 0 replies; 4+ messages in thread From: James Bottomley @ 2015-05-06 14:23 UTC (permalink / raw) To: Ian Jackson Cc: linux-scsi, linux-kernel, xen-devel, James Bottomley, Donald D Dugger, Pawel Baldysiak, Lukasz Dorau, Artur Paszkiewicz, Ian Campbell, Konrad Rzeszutek Wilk, Boris Ostrovsky, David Vrabel On Fri, 2015-05-01 at 15:36 +0100, Ian Jackson wrote: > SATA controllers support SATA disks. The kernel should be able to > drive these, by default. It should not silently (apart from a > debugging-only printk) ignore them. To be honest, this is a bit pointless: no distribution takes the kernel defaults anyway so changing it achieves nothing. The original thought behind doing this is that libata was huge and is pulled in by the sata code whether its actually used or not. Certain configurations might not want this. However, I think we can all agree that the major SAS user is enterprise and for them, kernel size isn't usually a huge worry. Even for enterprise, the predominant configuration seems to be SAS expanders with SATA drives, so they can't turn it off anyway. Therefore a more useful question might be: is it time to remove the option entirely? James ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-06 14:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <21826.14993.432271.52216@mariner.uk.xensource.com>
2015-05-01 14:36 ` [PATCH] [SCSI] libsas: Kconfig: Enable SATA compatibility by default Ian Jackson
2015-05-03 13:07 ` Julian Calaby
2015-05-06 14:03 ` Ian Jackson
2015-05-06 14:23 ` James Bottomley
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox