From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
Dolev Raviv <draviv@codeaurora.org>,
Sujit Reddy Thumma <sthumma@codeaurora.org>,
Subhash Jadavani <subhashj@codeaurora.org>,
Christoph Hellwig <hch@lst.de>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
"David S. Miller" <davem@davemloft.net>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH v7] scsi: ufs & esp_scsi: fix module reference counting
Date: Mon, 11 May 2015 22:18:31 +0900 [thread overview]
Message-ID: <1431350313-5009-1-git-send-email-akinobu.mita@gmail.com> (raw)
While accessing a scsi_device, the use count of the underlying LLDD
module is incremented. The module reference is retrieved through
.module field of struct scsi_host_template.
This mapping between scsi_device and underlying LLDD module works well
except ufs and esp scsi drivers. These drivers consist with core
driver and actual LLDDs, and scsi_host_template is defined in the core
driver. Since the module reference count isn't incremented, the
actual LLDDs can be unloaded while the scsi_device is being accessed.
This fixes it by preparing scsi host template for each LLDDs, which
is initialized at module_init().
* v7:
- Patch series is almost rewritten again and no scsi mid layer change
anymore. This fixes the issue by preparing scsi host template for
each LLDDs, which is initialized at module_init().
The idea is provided by James Bottomley
- The patch for usb-storage was removed as it was added to usb-testing
* v6:
- Rebased as v5 doesn't apply cleanly to the latest tree anymore.
* v5:
- Discard v4 changes and restore to v3. Because v4 shows that
moving owner module field from scsi_host_template to Scsi_Host
requires a lot of changes and introduces complication to existing
drivers which don't have the module reference mismatch issue.
- Rebased to the 4.0-rc1
* v4:
- Patch series is almost rewritten as module reference field in
struct scsi_host_template has been unused anymore. So Acked-by: and
Reviewed-by: tags that have been received are deleted.
* v3:
- Add fix for ESP SCSI drivers
* v2:
- Pass correct module reference to usb_stor_probe1() instead of touching
all ums-* drivers, suggested by Alan Stern
Akinobu Mita (2):
scsi: ufs: fix module reference for scsi host
scsi: esp_scsi: fix module reference for scsi host
drivers/scsi/am53c974.c | 7 +++++--
drivers/scsi/esp_scsi.c | 13 +++++++++++--
drivers/scsi/esp_scsi.h | 9 +++++++--
drivers/scsi/jazz_esp.c | 7 +++++--
drivers/scsi/mac_esp.c | 7 +++++--
drivers/scsi/sun3x_esp.c | 7 +++++--
drivers/scsi/sun_esp.c | 7 +++++--
drivers/scsi/ufs/ufshcd-pci.c | 19 +++++++++++++++++--
drivers/scsi/ufs/ufshcd-pltfrm.c | 19 +++++++++++++++++--
drivers/scsi/ufs/ufshcd.c | 19 +++++++++++++++----
drivers/scsi/ufs/ufshcd.h | 5 ++++-
11 files changed, 96 insertions(+), 23 deletions(-)
Cc: Vinayak Holikatti <vinholikatti@gmail.com>
Cc: Dolev Raviv <draviv@codeaurora.org>
Cc: Sujit Reddy Thumma <sthumma@codeaurora.org>
Cc: Subhash Jadavani <subhashj@codeaurora.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Hannes Reinecke <hare@suse.de>
Cc: linux-scsi@vger.kernel.org
--
1.9.1
next reply other threads:[~2015-05-11 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 13:18 Akinobu Mita [this message]
2015-05-11 13:18 ` [PATCH v7] scsi: ufs: fix module reference for scsi host Akinobu Mita
2015-05-11 13:18 ` [PATCH v7] scsi: esp_scsi: " Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431350313-5009-1-git-send-email-akinobu.mita@gmail.com \
--to=akinobu.mita@gmail.com \
--cc=JBottomley@parallels.com \
--cc=davem@davemloft.net \
--cc=draviv@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=stern@rowland.harvard.edu \
--cc=sthumma@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox