public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Narsimhulu Musini <nmusini@cisco.com>
Cc: linux-scsi@vger.kernel.org, hare@suse.de
Subject: Re: [PATCH v5 0/9] snic:initial submission of snic driver for Cisco SCSI HBA
Date: Fri, 15 May 2015 08:49:46 -0700	[thread overview]
Message-ID: <1431704986.2295.2.camel@HansenPartnership.com> (raw)
In-Reply-To: <1429694642-22309-1-git-send-email-nmusini@cisco.com>

On Wed, 2015-04-22 at 02:23 -0700, Narsimhulu Musini wrote:
> The following patch series adds snic driver for Cisco SCSI HBA
> 
> Cisco has developed a new PCI HBA interface called sNIC, which stands for 
> SCSI NIC. This is a new storage feature supported on specialized network
> adapter. The new PCI function provides a uniform host interface and abstracts
> backend storage.
> 
> * v5
> - Incorporated Dr. Hannes Reinecke's review comments.
> 
> * v4
> - Incorporated Christoph Hellwig's comments.
> 
> * v3
> - Incorporated Dr. Hannes Reinecke's review comments.
> 
> * v2
> - Incorporated Dr. Hannes Reinecke's review comments.
> 
> 	Thanks
> 	Narsimhulu Musini & Sesidhar Baddela
> 
> Narsimhulu Musini (9):
>   snic: snic module infrastructure
>   snic:Add interrupt, resource firmware interfaces
>   snic:Add meta request,  handling of meta requests.
>   snic:Add snic target discovery
>   snic:add SCSI handling, AEN, and fwreset handling
>   snic:Add low level queuing interfaces
>   snic:Add sysfs entries to list stats and trace data
>   snic:Add event tracing to capture IO events.
>   snic:Add Makefile, patch Kconfig, MAINTAINERS
> 
>  MAINTAINERS                       |    7 +
>  drivers/scsi/Kconfig              |   17 +
>  drivers/scsi/Makefile             |    1 +
>  drivers/scsi/snic/Makefile        |   21 +
>  drivers/scsi/snic/cq_desc.h       |   76 ++
>  drivers/scsi/snic/cq_enet_desc.h  |   38 +
>  drivers/scsi/snic/snic.h          |  415 ++++++
>  drivers/scsi/snic/snic_attrs.c    |   79 ++
>  drivers/scsi/snic/snic_ctl.c      |  276 ++++
>  drivers/scsi/snic/snic_debugfs.c  |  562 ++++++++
>  drivers/scsi/snic/snic_disc.c     |  602 +++++++++
>  drivers/scsi/snic/snic_disc.h     |  124 ++
>  drivers/scsi/snic/snic_fwint.h    |  525 ++++++++
>  drivers/scsi/snic/snic_io.c       |  519 ++++++++
>  drivers/scsi/snic/snic_io.h       |  118 ++
>  drivers/scsi/snic/snic_isr.c      |  209 +++
>  drivers/scsi/snic/snic_main.c     | 1039 +++++++++++++++
>  drivers/scsi/snic/snic_res.c      |  297 +++++
>  drivers/scsi/snic/snic_res.h      |   96 ++
>  drivers/scsi/snic/snic_scsi.c     | 2640 +++++++++++++++++++++++++++++++++++++
>  drivers/scsi/snic/snic_stats.h    |  123 ++
>  drivers/scsi/snic/snic_trc.c      |  182 +++
>  drivers/scsi/snic/snic_trc.h      |  121 ++
>  drivers/scsi/snic/vnic_cq.c       |   86 ++
>  drivers/scsi/snic/vnic_cq.h       |  110 ++
>  drivers/scsi/snic/vnic_cq_fw.h    |   62 +
>  drivers/scsi/snic/vnic_dev.c      |  748 +++++++++++
>  drivers/scsi/snic/vnic_dev.h      |  110 ++
>  drivers/scsi/snic/vnic_devcmd.h   |  270 ++++
>  drivers/scsi/snic/vnic_intr.c     |   59 +
>  drivers/scsi/snic/vnic_intr.h     |  105 ++
>  drivers/scsi/snic/vnic_resource.h |   68 +
>  drivers/scsi/snic/vnic_snic.h     |   54 +
>  drivers/scsi/snic/vnic_stats.h    |   68 +
>  drivers/scsi/snic/vnic_wq.c       |  237 ++++
>  drivers/scsi/snic/vnic_wq.h       |  170 +++
>  drivers/scsi/snic/wq_enet_desc.h  |   91 ++
>  37 files changed, 10325 insertions(+)
>  create mode 100644 drivers/scsi/snic/Makefile
>  create mode 100644 drivers/scsi/snic/cq_desc.h
>  create mode 100644 drivers/scsi/snic/cq_enet_desc.h
>  create mode 100644 drivers/scsi/snic/snic.h
>  create mode 100644 drivers/scsi/snic/snic_attrs.c
>  create mode 100644 drivers/scsi/snic/snic_ctl.c
>  create mode 100644 drivers/scsi/snic/snic_debugfs.c
>  create mode 100644 drivers/scsi/snic/snic_disc.c
>  create mode 100644 drivers/scsi/snic/snic_disc.h
>  create mode 100644 drivers/scsi/snic/snic_fwint.h
>  create mode 100644 drivers/scsi/snic/snic_io.c
>  create mode 100644 drivers/scsi/snic/snic_io.h
>  create mode 100644 drivers/scsi/snic/snic_isr.c
>  create mode 100644 drivers/scsi/snic/snic_main.c
>  create mode 100644 drivers/scsi/snic/snic_res.c
>  create mode 100644 drivers/scsi/snic/snic_res.h
>  create mode 100644 drivers/scsi/snic/snic_scsi.c
>  create mode 100644 drivers/scsi/snic/snic_stats.h
>  create mode 100644 drivers/scsi/snic/snic_trc.c
>  create mode 100644 drivers/scsi/snic/snic_trc.h
>  create mode 100644 drivers/scsi/snic/vnic_cq.c
>  create mode 100644 drivers/scsi/snic/vnic_cq.h
>  create mode 100644 drivers/scsi/snic/vnic_cq_fw.h
>  create mode 100644 drivers/scsi/snic/vnic_dev.c
>  create mode 100644 drivers/scsi/snic/vnic_dev.h
>  create mode 100644 drivers/scsi/snic/vnic_devcmd.h
>  create mode 100644 drivers/scsi/snic/vnic_intr.c
>  create mode 100644 drivers/scsi/snic/vnic_intr.h
>  create mode 100644 drivers/scsi/snic/vnic_resource.h
>  create mode 100644 drivers/scsi/snic/vnic_snic.h
>  create mode 100644 drivers/scsi/snic/vnic_stats.h
>  create mode 100644 drivers/scsi/snic/vnic_wq.c
>  create mode 100644 drivers/scsi/snic/vnic_wq.h
>  create mode 100644 drivers/scsi/snic/wq_enet_desc.h

This doesn't build on 32 bits.  Is it supposed to be 64 bit only?

  CC [M]  drivers/scsi/snic/snic_attrs.o
  CC [M]  drivers/scsi/snic/snic_main.o
  CC [M]  drivers/scsi/snic/snic_isr.o
  CC [M]  drivers/scsi/snic/snic_res.o
  CC [M]  drivers/scsi/snic/snic_ctl.o
  CC [M]  drivers/scsi/snic/snic_io.o
  CC [M]  drivers/scsi/snic/snic_disc.o
  CC [M]  drivers/scsi/snic/snic_scsi.o
drivers/scsi/snic/snic_ctl.c: In function ‘snic_queue_exch_ver_req’:
drivers/scsi/snic/snic_ctl.c:130:25: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
    snic->config.hid, 0, (u64)rqi);
                         ^
drivers/scsi/snic/snic_ctl.c: In function
‘snic_io_exch_ver_cmpl_handler’:
drivers/scsi/snic/snic_ctl.c:167:8: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
  rqi = (struct snic_req_info *) ctx;
        ^
  CC [M]  drivers/scsi/snic/vnic_cq.o
In file included from drivers/scsi/snic/snic.h:33:0,
                 from drivers/scsi/snic/snic_io.c:29:
drivers/scsi/snic/snic_io.c: In function ‘snic_wq_cmpl_frame_send’:
drivers/scsi/snic/snic_io.c:49:5: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
    ((u64)(buf->os_buf) - sizeof(struct snic_req_info)), 0, 0, 0);
     ^
drivers/scsi/snic/snic_trc.h:90:14: note: in definition of macro
‘SNIC_TRC’
        (u64)(d2),    \
              ^
In file included from drivers/scsi/snic/snic_io.c:28:0:
drivers/scsi/snic/snic_io.c: In function ‘snic_free_wq_buf’:
drivers/scsi/snic/snic_io.h:104:3: warning: cast to pointer from integer
of different size [-Wint-to-pointer-cast]
  ((struct snic_req_info *) (((struct snic_host_req
*)req)->hdr.init_ctx))
   ^
drivers/scsi/snic/snic_io.c:106:8: note: in expansion of macro
‘req_to_rqi’
  rqi = req_to_rqi(req);
        ^
drivers/scsi/snic/snic_io.c:119:9: warning: cast to pointer from integer
of different size [-Wint-to-pointer-cast]
   kfree((void *)rqi->sge_va);
         ^
drivers/scsi/snic/snic_io.c: In function ‘snic_req_init’:
drivers/scsi/snic/snic_io.c:245:27: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
  rqi->req->hdr.init_ctx = (u64) rqi;
                           ^
drivers/scsi/snic/snic_io.c: In function ‘snic_abort_req_init’:
drivers/scsi/snic/snic_io.c:278:22: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
  req->hdr.init_ctx = (u64) rqi;
                      ^
drivers/scsi/snic/snic_io.c: In function ‘snic_dr_req_init’:
drivers/scsi/snic/snic_io.c:305:22: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
  req->hdr.init_ctx = (u64) rqi;
                      ^
drivers/scsi/snic/snic_io.c: In function ‘snic_free_all_untagged_reqs’:
drivers/scsi/snic/snic_io.c:360:10: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
    kfree((void *)rqi->sge_va);
          ^
drivers/scsi/snic/snic_io.c: In function ‘snic_dump_desc’:
drivers/scsi/snic/snic_io.c:416:9: warning: cast to pointer from integer
of different size [-Wint-to-pointer-cast]
   rqi = (struct snic_req_info *) fwreq->hdr.init_ctx;
         ^
drivers/scsi/snic/snic_io.c:418:9: warning: cast to pointer from integer
of different size [-Wint-to-pointer-cast]
   rqi = (struct snic_req_info *) req->hdr.init_ctx;
         ^
  CC [M]  drivers/scsi/snic/vnic_intr.o
In file included from include/uapi/linux/stddef.h:1:0,
                 from include/linux/stddef.h:4,
                 from ./include/uapi/linux/posix_types.h:4,
                 from include/uapi/linux/types.h:13,
                 from include/linux/types.h:5,
                 from include/linux/mod_devicetable.h:11,
                 from include/linux/pci.h:20,
                 from drivers/scsi/snic/snic_io.c:19:
drivers/scsi/snic/snic_io.c: In function ‘snic_req_init’:
include/linux/compiler.h:408:20: error: call to
‘__compiletime_assert_226’ declared with attribute error: BUILD_BUG_ON
failed: (sizeof(struct snic_req_info) % SNIC_SG_DESC_ALIGN) != 0
    prefix ## suffix();    \
                    ^
include/linux/compiler.h:413:2: note: in expansion of macro
‘__compiletime_assert’
  __compiletime_assert(condition, msg, prefix, suffix)
  ^
include/linux/compiler.h:425:2: note: in expansion of macro
‘_compiletime_assert’
  _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
  ^
include/linux/bug.h:50:37: note: in expansion of macro
‘compiletime_assert’
 #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
                                     ^
include/linux/bug.h:74:2: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
  BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
  ^
drivers/scsi/snic/snic_io.c:226:2: note: in expansion of macro
‘BUILD_BUG_ON’
  BUILD_BUG_ON((sizeof(struct snic_req_info) % SNIC_SG_DESC_ALIGN) !=
0);
  ^
  CC [M]  drivers/scsi/snic/vnic_dev.o
scripts/Makefile.build:258: recipe for target
'drivers/scsi/snic/snic_io.o' failed
make[3]: *** [drivers/scsi/snic/snic_io.o] Error 1
make[3]: *** Waiting for unfinished jobs....
drivers/scsi/snic/snic_scsi.c: In function ‘snic_queue_icmnd_req’:
drivers/scsi/snic/snic_scsi.c:212:4: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
    (u64)rqi,
    ^
drivers/scsi/snic/snic_scsi.c:220:4: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
    (u64)req_to_sgl(rqi->req),
    ^
In file included from drivers/scsi/snic/snic.h:33:0,
                 from drivers/scsi/snic/snic_scsi.c:34:
drivers/scsi/snic/snic_scsi.c: In function ‘snic_issue_scsi_req’:
drivers/scsi/snic/snic_scsi.c:253:44: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
   SNIC_TRC((u16)snic->shost->host_no, tag, (u64)sc, 0,
                                            ^
drivers/scsi/snic/snic_trc.h:89:14: note: in definition of macro
‘SNIC_TRC’
        (u64)(d1),    \
              ^
drivers/scsi/snic/snic_scsi.c:297:39: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
   SNIC_TRC(snic->shost->host_no, tag, (u64)sc, 0, 0, 0,
                                       ^
drivers/scsi/snic/snic_trc.h:89:14: note: in definition of macro
‘SNIC_TRC’
        (u64)(d1),    \
              ^
drivers/scsi/snic/snic_scsi.c:314:39: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
   SNIC_TRC(snic->shost->host_no, tag, (u64)sc, (u64)rqi, sg_cnt,
                                       ^
drivers/scsi/snic/snic_trc.h:89:14: note: in definition of macro
‘SNIC_TRC’
        (u64)(d1),    \
              ^
drivers/scsi/snic/snic_scsi.c:314:48: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
   SNIC_TRC(snic->shost->host_no, tag, (u64)sc, (u64)rqi, sg_cnt,
                                                ^
drivers/scsi/snic/snic_trc.h:90:14: note: in definition of macro
‘SNIC_TRC’
        (u64)(d2),    \
              ^
drivers/scsi/snic/snic_scsi.c: In function ‘snic_icmnd_cmpl_handler’:
drivers/scsi/snic/snic_trc.h:91:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d3),    \
        ^
drivers/scsi/snic/snic_scsi.c:588:3: note: in expansion of macro
‘SNIC_TRC’
   SNIC_TRC(snic->shost->host_no, cmnd_id, 0,
   ^
In file included from drivers/scsi/snic/snic_scsi.c:34:0:
drivers/scsi/snic/snic_scsi.c:610:21: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
  SNIC_BUG_ON(rqi != (struct snic_req_info *)ctx);
                     ^
drivers/scsi/snic/snic.h:184:7: note: in definition of macro
‘SNIC_BUG_ON’
   if (EXPR) { \
       ^
In file included from ./arch/x86/include/asm/bug.h:35:0,
                 from include/linux/bug.h:4,
                 from include/linux/thread_info.h:11,
                 from ./arch/x86/include/asm/preempt.h:6,
                 from include/linux/preempt.h:18,
                 from include/linux/spinlock.h:50,
                 from include/linux/wait.h:8,
                 from include/linux/mempool.h:7,
                 from drivers/scsi/snic/snic_scsi.c:18:
drivers/scsi/snic/snic_scsi.c:610:21: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
  SNIC_BUG_ON(rqi != (struct snic_req_info *)ctx);
                     ^
include/asm-generic/bug.h:111:27: note: in definition of macro
‘WARN_ON_ONCE’
  int __ret_warn_once = !!(condition);   \
                           ^
drivers/scsi/snic/snic_scsi.c:610:2: note: in expansion of macro
‘SNIC_BUG_ON’
  SNIC_BUG_ON(rqi != (struct snic_req_info *)ctx);
  ^
drivers/scsi/snic/snic_scsi.c:624:8: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
  rqi = (struct snic_req_info *) ctx;
        ^
In file included from drivers/scsi/snic/snic.h:33:0,
                 from drivers/scsi/snic/snic_scsi.c:34:
drivers/scsi/snic/snic_trc.h:89:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d1),    \
        ^
drivers/scsi/snic/snic_scsi.c:650:3: note: in expansion of macro
‘SNIC_TRC’
   SNIC_TRC(snic->shost->host_no, cmnd_id, sc,
   ^
drivers/scsi/snic/snic_trc.h:91:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d3),    \
        ^
drivers/scsi/snic/snic_scsi.c:650:3: note: in expansion of macro
‘SNIC_TRC’
   SNIC_TRC(snic->shost->host_no, cmnd_id, sc,
   ^
drivers/scsi/snic/snic_scsi.c:678:42: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
  SNIC_TRC(snic->shost->host_no, cmnd_id, (u64)sc,
                                          ^
drivers/scsi/snic/snic_trc.h:89:14: note: in definition of macro
‘SNIC_TRC’
        (u64)(d1),    \
              ^
drivers/scsi/snic/snic_scsi.c:679:44: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
    jiffies_to_msecs(jiffies - start_time), (u64)fwreq,
                                            ^
drivers/scsi/snic/snic_trc.h:91:14: note: in definition of macro
‘SNIC_TRC’
        (u64)(d3),    \
              ^
drivers/scsi/snic/snic_scsi.c: In function ‘snic_proc_dr_cmpl_locked’:
drivers/scsi/snic/snic_trc.h:89:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d1),    \
        ^
drivers/scsi/snic/snic_scsi.c:707:3: note: in expansion of macro
‘SNIC_TRC’
   SNIC_TRC(snic->shost->host_no, cmnd_id, sc,
   ^
drivers/scsi/snic/snic_trc.h:91:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d3),    \
        ^
drivers/scsi/snic/snic_scsi.c:707:3: note: in expansion of macro
‘SNIC_TRC’
   SNIC_TRC(snic->shost->host_no, cmnd_id, sc,
   ^
drivers/scsi/snic/snic_trc.h:89:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d1),    \
        ^
drivers/scsi/snic/snic_scsi.c:722:3: note: in expansion of macro
‘SNIC_TRC’
   SNIC_TRC(snic->shost->host_no, cmnd_id, sc,
   ^
drivers/scsi/snic/snic_trc.h:91:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d3),    \
        ^
drivers/scsi/snic/snic_scsi.c:722:3: note: in expansion of macro
‘SNIC_TRC’
   SNIC_TRC(snic->shost->host_no, cmnd_id, sc,
   ^
drivers/scsi/snic/snic_scsi.c: In function ‘snic_process_itmf_cmpl’:
drivers/scsi/snic/snic_trc.h:89:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d1),    \
        ^
drivers/scsi/snic/snic_scsi.c:858:4: note: in expansion of macro
‘SNIC_TRC’
    SNIC_TRC(snic->shost->host_no, cmnd_id, sc,
    ^
drivers/scsi/snic/snic_trc.h:91:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d3),    \
        ^
drivers/scsi/snic/snic_scsi.c:858:4: note: in expansion of macro
‘SNIC_TRC’
    SNIC_TRC(snic->shost->host_no, cmnd_id, sc,
    ^
drivers/scsi/snic/snic_scsi.c: In function ‘snic_itmf_cmpl_handler’:
drivers/scsi/snic/snic_scsi.c:943:9: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
   rqi = (struct snic_req_info *) ctx;
         ^
drivers/scsi/snic/snic_scsi.c: In function
‘snic_hba_reset_cmpl_handler’:
drivers/scsi/snic/snic_scsi.c:1025:9: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
   rqi = (struct snic_req_info *) ctx;
         ^
In file included from drivers/scsi/snic/snic_scsi.c:33:0:
drivers/scsi/snic/snic_scsi.c: In function ‘snic_queue_itmf_req’:
drivers/scsi/snic/snic_io.h:104:3: warning: cast to pointer from integer
of different size [-Wint-to-pointer-cast]
  ((struct snic_req_info *) (((struct snic_host_req
*)req)->hdr.init_ctx))
   ^
drivers/scsi/snic/snic_scsi.c:1302:30: note: in expansion of macro
‘req_to_rqi’
  struct snic_req_info *rqi = req_to_rqi(tmreq);
                              ^
drivers/scsi/snic/snic_scsi.c:1317:10: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
          (u64) rqi,
          ^
In file included from drivers/scsi/snic/snic.h:33:0,
                 from drivers/scsi/snic/snic_scsi.c:34:
drivers/scsi/snic/snic_scsi.c: In function ‘snic_abort_cmd’:
drivers/scsi/snic/snic_trc.h:89:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d1),    \
        ^
drivers/scsi/snic/snic_scsi.c:1642:2: note: in expansion of macro
‘SNIC_TRC’
  SNIC_TRC(snic->shost->host_no, tag, sc,
  ^
drivers/scsi/snic/snic_scsi.c: In function
‘snic_unlink_and_release_req’:
drivers/scsi/snic/snic_trc.h:89:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d1),    \
        ^
drivers/scsi/snic/snic_scsi.c:2114:2: note: in expansion of macro
‘SNIC_TRC’
  SNIC_TRC(snic->shost->host_no, snic_cmd_tag(sc), sc,
  ^
drivers/scsi/snic/snic_trc.h:91:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d3),    \
        ^
drivers/scsi/snic/snic_scsi.c:2114:2: note: in expansion of macro
‘SNIC_TRC’
  SNIC_TRC(snic->shost->host_no, snic_cmd_tag(sc), sc,
  ^
drivers/scsi/snic/snic_scsi.c: In function ‘snic_device_reset’:
drivers/scsi/snic/snic_trc.h:89:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d1),    \
        ^
drivers/scsi/snic/snic_scsi.c:2187:2: note: in expansion of macro
‘SNIC_TRC’
  SNIC_TRC(snic->shost->host_no, tag, sc,
  ^
drivers/scsi/snic/snic_scsi.c: In function ‘snic_issue_hba_reset’:
drivers/scsi/snic/snic_scsi.c:2245:25: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
    snic->config.hid, 0, (u64)rqi);
                         ^
In file included from drivers/scsi/snic/snic.h:33:0,
                 from drivers/scsi/snic/snic_scsi.c:34:
drivers/scsi/snic/snic_scsi.c: In function ‘snic_host_reset’:
drivers/scsi/snic/snic_trc.h:89:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d1),    \
        ^
drivers/scsi/snic/snic_scsi.c:2376:2: note: in expansion of macro
‘SNIC_TRC’
  SNIC_TRC(shost->host_no, snic_cmd_tag(sc), sc,
  ^
drivers/scsi/snic/snic_scsi.c: In function ‘snic_scsi_cleanup’:
drivers/scsi/snic/snic_trc.h:89:8: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]
        (u64)(d1),    \
        ^
drivers/scsi/snic/snic_scsi.c:2477:4: note: in expansion of macro
‘SNIC_TRC’
    SNIC_TRC(snic->shost->host_no, tag, sc,
    ^
drivers/scsi/snic/snic_disc.c: In function ‘snic_report_tgt_init’:
drivers/scsi/snic/snic_disc.c:73:28: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
  req->u.rpt_tgts.sg_addr = (u64) sgd;
                            ^
drivers/scsi/snic/snic_disc.c: In function ‘snic_queue_report_tgt_req’:
drivers/scsi/snic/snic_disc.c:128:16: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
  rqi->sge_va = (u64) buf;
                ^
drivers/scsi/snic/snic_disc.c:135:9: warning: cast from pointer to
integer of different size [-Wpointer-to-int-cast]
         (u64)rqi);
         ^
drivers/scsi/snic/snic_disc.c: In function
‘snic_report_tgt_cmpl_handler’:
drivers/scsi/snic/snic_disc.c:405:8: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
  rqi = (struct snic_req_info *)ctx;
        ^
drivers/scsi/snic/snic_disc.c:406:10: warning: cast to pointer from
integer of different size [-Wint-to-pointer-cast]
  tgtid = (struct snic_tgt_id *) (rqi->sge_va);
          ^
scripts/Makefile.build:403: recipe for target 'drivers/scsi/snic' failed

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-05-15 15:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22  9:23 [PATCH v5 0/9] snic:initial submission of snic driver for Cisco SCSI HBA Narsimhulu Musini
2015-04-22  9:23 ` [PATCH v5 1/9] snic: snic module infrastructure Narsimhulu Musini
2015-05-11 17:55   ` Hannes Reinecke
2015-04-22  9:23 ` [PATCH v5 2/9] snic:Add interrupt, resource firmware interfaces Narsimhulu Musini
2015-05-11 17:55   ` Hannes Reinecke
2015-04-22  9:23 ` [PATCH v5 3/9] snic:Add meta request, handling of meta requests Narsimhulu Musini
2015-05-11 17:56   ` Hannes Reinecke
2015-04-22  9:23 ` [PATCH v5 4/9] snic:Add snic target discovery Narsimhulu Musini
2015-05-11 17:58   ` Hannes Reinecke
2015-04-22  9:23 ` [PATCH v5 5/9] snic:add SCSI handling, AEN, and fwreset handling Narsimhulu Musini
2015-05-11 18:00   ` Hannes Reinecke
2015-04-22  9:23 ` [PATCH v5 6/9] snic:Add low level queuing interfaces Narsimhulu Musini
2015-05-11 18:01   ` Hannes Reinecke
2015-04-22  9:24 ` [PATCH v5 7/9] snic:Add sysfs entries to list stats and trace data Narsimhulu Musini
2015-05-11 18:02   ` Hannes Reinecke
2015-04-22  9:24 ` [PATCH v5 8/9] snic:Add event tracing to capture IO events Narsimhulu Musini
2015-05-11 18:03   ` Hannes Reinecke
2015-04-22  9:24 ` [PATCH v5 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS Narsimhulu Musini
2015-05-11 18:03   ` Hannes Reinecke
2015-05-15 15:49 ` James Bottomley [this message]
2015-05-15 16:08   ` [PATCH v5 0/9] snic:initial submission of snic driver for Cisco SCSI HBA Narsimhulu Musini (nmusini)
2015-05-15 16:34     ` James Bottomley
2015-05-18  4:21       ` Narsimhulu Musini (nmusini)
2015-05-18 14:35         ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431704986.2295.2.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=hare@suse.de \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nmusini@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox