public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-scsi@vger.kernel.org, "James E.J. Bottomley" <JBottomley@odin.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>, Adam Radford <linuxraid@lsi.com>
Subject: [PATCH 3/7] 3w-9xxx: fix transfer length 0 for 6-byte r/w commands
Date: Sat, 16 May 2015 16:17:49 +0900	[thread overview]
Message-ID: <1431760673-7180-4-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1431760673-7180-1-git-send-email-akinobu.mita@gmail.com>

For 6-byte r/w commands, transfer length 0 means 256 blocks of data,
not 0 block.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Adam Radford <linuxraid@lsi.com>
Cc: linux-scsi@vger.kernel.org
---
 drivers/scsi/3w-9xxx.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c
index add419d..71ddb7f 100644
--- a/drivers/scsi/3w-9xxx.c
+++ b/drivers/scsi/3w-9xxx.c
@@ -1870,8 +1870,11 @@ static int twa_scsiop_execute_scsi(TW_Device_Extension *tw_dev, int request_id,
 	}
 
 	if (srb) {
-		if (srb->cmnd[0] == READ_6 || srb->cmnd[0] == WRITE_6)
+		if (srb->cmnd[0] == READ_6 || srb->cmnd[0] == WRITE_6) {
 			num_sectors = (u32)srb->cmnd[4];
+			if (num_sectors == 0)
+				num_sectors = 256;
+		}
 
 		if (srb->cmnd[0] == READ_10 || srb->cmnd[0] == WRITE_10)
 			num_sectors = (u32)srb->cmnd[8] | ((u32)srb->cmnd[7] << 8);
-- 
1.9.1


  parent reply	other threads:[~2015-05-16  7:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-16  7:17 [PATCH 0/7] scsi: Fix transfer length 0 for 6-byte r/w commands Akinobu Mita
2015-05-16  7:17 ` [PATCH 1/7] hpsa: fix " Akinobu Mita
2015-05-16  7:17 ` [PATCH 2/7] 3w-xxxx: " Akinobu Mita
2015-05-16  7:17 ` Akinobu Mita [this message]
2015-05-16  7:17 ` [PATCH 4/7] scsi: trace: " Akinobu Mita
2015-05-16  7:17 ` [PATCH 5/7] staging: rts5208: " Akinobu Mita
2015-05-16  7:17 ` [PATCH 6/7] megaraid_mbox: " Akinobu Mita
2015-05-16  7:17 ` [PATCH 7/7] megaraid: " Akinobu Mita
2015-05-16 16:46 ` [PATCH 0/7] scsi: Fix " James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1431760673-7180-4-git-send-email-akinobu.mita@gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=JBottomley@odin.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxraid@lsi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox