From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Narsimhulu Musini (nmusini)" <nmusini@cisco.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hare@suse.de" <hare@suse.de>
Subject: Re: [PATCH v5 0/9] snic:initial submission of snic driver for Cisco SCSI HBA
Date: Mon, 18 May 2015 07:35:17 -0700 [thread overview]
Message-ID: <1431959717.2256.2.camel@HansenPartnership.com> (raw)
In-Reply-To: <D17F6556.25AFA%nmusini@cisco.com>
On Mon, 2015-05-18 at 04:21 +0000, Narsimhulu Musini (nmusini) wrote:
> Hi James,
>
> Added dependency in Kconfig for x86 to avoid its inclusion on other
> architectures. Will it be help, if it is changed to x86_64?.
Not really. The problem is that if you introduce code that isn't clean
from the bit width or endianness perspective, the static checkers will
pick it up and flag it and we'll just get a flood of errors reported in
the driver. Plus from the maintenance perspective, the code needs to be
clean (which is why the static checkers are looking for this).
James
prev parent reply other threads:[~2015-05-18 14:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 9:23 [PATCH v5 0/9] snic:initial submission of snic driver for Cisco SCSI HBA Narsimhulu Musini
2015-04-22 9:23 ` [PATCH v5 1/9] snic: snic module infrastructure Narsimhulu Musini
2015-05-11 17:55 ` Hannes Reinecke
2015-04-22 9:23 ` [PATCH v5 2/9] snic:Add interrupt, resource firmware interfaces Narsimhulu Musini
2015-05-11 17:55 ` Hannes Reinecke
2015-04-22 9:23 ` [PATCH v5 3/9] snic:Add meta request, handling of meta requests Narsimhulu Musini
2015-05-11 17:56 ` Hannes Reinecke
2015-04-22 9:23 ` [PATCH v5 4/9] snic:Add snic target discovery Narsimhulu Musini
2015-05-11 17:58 ` Hannes Reinecke
2015-04-22 9:23 ` [PATCH v5 5/9] snic:add SCSI handling, AEN, and fwreset handling Narsimhulu Musini
2015-05-11 18:00 ` Hannes Reinecke
2015-04-22 9:23 ` [PATCH v5 6/9] snic:Add low level queuing interfaces Narsimhulu Musini
2015-05-11 18:01 ` Hannes Reinecke
2015-04-22 9:24 ` [PATCH v5 7/9] snic:Add sysfs entries to list stats and trace data Narsimhulu Musini
2015-05-11 18:02 ` Hannes Reinecke
2015-04-22 9:24 ` [PATCH v5 8/9] snic:Add event tracing to capture IO events Narsimhulu Musini
2015-05-11 18:03 ` Hannes Reinecke
2015-04-22 9:24 ` [PATCH v5 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS Narsimhulu Musini
2015-05-11 18:03 ` Hannes Reinecke
2015-05-15 15:49 ` [PATCH v5 0/9] snic:initial submission of snic driver for Cisco SCSI HBA James Bottomley
2015-05-15 16:08 ` Narsimhulu Musini (nmusini)
2015-05-15 16:34 ` James Bottomley
2015-05-18 4:21 ` Narsimhulu Musini (nmusini)
2015-05-18 14:35 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431959717.2256.2.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nmusini@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox