From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Sumit.Saxena@avagotech.com
Cc: linux-scsi@vger.kernel.org, thenzl@redhat.com,
martin.petersen@oracle.com, hch@infradead.org,
kashyap.desai@avagotech.com
Subject: Re: [PATCH v3 4/18] megaraid_sas : Move controller's queue depth calculation in adapter specific function
Date: Mon, 18 May 2015 23:22:27 -0700 [thread overview]
Message-ID: <1432016547.4337.61.camel@HansenPartnership.com> (raw)
In-Reply-To: <201504231103.t3NB3Ajm029643@palmhbs0.lsi.com>
On Thu, 2015-04-23 at 16:30 +0530, Sumit.Saxena@avagotech.com wrote:
> This patch will move internal commands and SCSI commands reservation
> in adapter's sepcific functions.
Commit messages like this aren't useful. It's just the subject with
"This patch will" added. The ideal is that you describe what's going on
at greater length in the commit message. However, if the subject says
it all, just leave the message blank rather than repeating the subject
(and making me excise it again).
James
next prev parent reply other threads:[~2015-05-19 6:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 11:00 [PATCH v3 4/18] megaraid_sas : Move controller's queue depth calculation in adapter specific function Sumit.Saxena
2015-05-19 6:22 ` James Bottomley [this message]
2015-05-19 7:32 ` Sumit Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432016547.4337.61.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=Sumit.Saxena@avagotech.com \
--cc=hch@infradead.org \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox