Re: [PATCH v3 17/18] megaraid_sas : fix megasas_fire_cmd_fusion calling convention

[James Bottomley <James.Bottomley@HansenPartnership.com>]

On Thu, 2015-04-23 at 16:34 +0530, Sumit.Saxena@avagotech.com wrote:
> The fusion HBAs don't really use the instance template like the other
> variants, as it branches off at a much higher level.  So instead of
> trying to squeeze megasas_fire_cmd_fusion into the wrong calling
> convention call it locally with argument data types that match what
> is passed.
> 
> From: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Tomas Henzl <thenzl@redhat.com>
> 
> ---
>  drivers/scsi/megaraid/megaraid_sas_fusion.c |   72 +++++++++++---------------
>  1 files changed, 31 insertions(+), 41 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> index 487cd34..826ba1c 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
> @@ -182,6 +182,31 @@ inline void megasas_return_cmd_fusion(struct megasas_instance *instance,
>  }
>  
>  /**
> + * megasas_fire_cmd_fusion -	Sends command to the FW
> + */
> +static void
> +megasas_fire_cmd_fusion(struct megasas_instance *instance,
> +		union MEGASAS_REQUEST_DESCRIPTOR_UNION *req_desc)
> +{
> +#if defined(writeq) && defined(CONFIG_64BIT)
> +	u64 req_data = (((u64)le32_to_cpu(req_desc->u.high) << 32) |
> +			le32_to_cpu(req_desc->u.low));
> +
> +	writeq(req_data, &instance->reg_set->inbound_low_queue_port);
> +#else
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&instance->hba_lock, flags);
> +	writel(le32_to_cpu(req_desc->u.low),
> +		&instance->reg_set->inbound_low_queue_port);
> +	writel(le32_to_cpu(req_desc.u.high),
                                    ^^^
Compile the bloody code.  This should be req_desc->u.high

I fixed it but I expect you to submit better code in future.

James