From: Yaniv Gardi <ygardi@codeaurora.org>
To: James.Bottomley@HansenPartnership.com, kishon@ti.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
ygardi@codeaurora.org, gbroner@codeaurora.org,
dovl@codeaurora.org
Subject: [PATCH v1 0/3] fixing building errors and warnings when components
Date: Tue, 19 May 2015 16:47:08 +0300 [thread overview]
Message-ID: <1432043231-31102-1-git-send-email-ygardi@codeaurora.org> (raw)
V1:
The following combination of components, when SCSI_UFS_QCOM=y
and PHY_QCOM_UFS=m is illegal and causes build errors.
The 3rd patch in the series enables the SCSI_UFS_QCOM component to
be compiled as a module (by changing its configuration to tristate).
So now, compiling SCSI_UFS_QCOM=m forces PHY_QCOM_UFS=m, and
SCSI_UFS_QCOM=y forces PHY_QCOM_UFS=y.
In addition, when PHY_QCOM_UFS=m, external functions in
phy-ufs-qcom.c should be exported. The 1st patch fixes it.
Another issue that we see when SCSI_UFS_QCOM=m is a warning that
the 2nd patch fixes.
notice:
checkpatch gives an error on the commit message of patch 1/3
in the series. Ignore as the commit message is the build errors
that this patch fixes.
Yaniv Gardi (3):
phy: qcom-ufs: fix build error when the driver is built as a module
scsi: ufs-qcom: fix compilation warning if compiled as a module
scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component
drivers/phy/phy-qcom-ufs.c | 11 +++++++++++
drivers/scsi/ufs/Kconfig | 2 +-
drivers/scsi/ufs/ufs-qcom.c | 2 +-
3 files changed, 13 insertions(+), 2 deletions(-)
--
1.8.5.2
--
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next reply other threads:[~2015-05-19 13:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 13:47 Yaniv Gardi [this message]
2015-05-19 13:47 ` [PATCH v1 1/3] phy: qcom-ufs: fix build error when the driver is built as a module Yaniv Gardi
2015-05-20 8:14 ` Paul Bolle
2015-05-20 9:40 ` ygardi
2015-05-19 13:47 ` [PATCH v1 2/3] scsi: ufs-qcom: fix compilation warning if compiled " Yaniv Gardi
2015-05-20 8:29 ` Paul Bolle
2015-05-20 13:49 ` ygardi
2015-05-19 13:47 ` [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component Yaniv Gardi
2015-05-20 7:21 ` Paul Bolle
2015-05-20 8:22 ` Paul Bolle
2015-05-21 7:16 ` Paul Bolle
2015-05-21 10:09 ` ygardi
2015-05-21 10:14 ` Paul Bolle
2015-05-21 17:18 ` ygardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432043231-31102-1-git-send-email-ygardi@codeaurora.org \
--to=ygardi@codeaurora.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dovl@codeaurora.org \
--cc=gbroner@codeaurora.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=santoshsy@gmail.com \
--cc=subhashj@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox