* [PATCH] SCSI: DTC: Adding KERN_ facility level
@ 2015-06-30 16:29 Rudhresh Kumar J
2015-08-25 1:53 ` Finn Thain
0 siblings, 1 reply; 2+ messages in thread
From: Rudhresh Kumar J @ 2015-06-30 16:29 UTC (permalink / raw)
To: fthain
Cc: schmitzmic, JBottomley, linux-scsi, linux-kernel,
Rudhresh Kumar J, Rudhresh Kumar J
Fixed coding style issue by adding KERN_ facility level to some of
the printk functions.
Signed-off-by: Rudhresh Kumar J <rudhresh.jk@gmail.com>
---
drivers/scsi/dtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
index 4c74c7b..a3a2a71 100644
--- a/drivers/scsi/dtc.c
+++ b/drivers/scsi/dtc.c
@@ -156,7 +156,7 @@ static int __init dtc_setup(char *str)
get_options(str, ARRAY_SIZE(ints), ints);
if (ints[0] != 2)
- printk("dtc_setup: usage dtc=address,irq\n");
+ printk(KERN_DEBUG "dtc_setup: usage dtc=address,irq\n");
else if (commandline_current < NO_OVERRIDES) {
overrides[commandline_current].address = ints[1];
overrides[commandline_current].irq = ints[2];
@@ -272,7 +272,7 @@ found:
instance->irq = NO_IRQ;
#endif
#if defined(DTCDEBUG) && (DTCDEBUG & DTCDEBUG_INIT)
- printk("scsi%d : irq = %d\n", instance->host_no, instance->irq);
+ printk(KERN_DEBUG "scsi%d : irq = %d\n", instance->host_no, instance->irq);
#endif
++current_override;
--
1.8.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] SCSI: DTC: Adding KERN_ facility level
2015-06-30 16:29 [PATCH] SCSI: DTC: Adding KERN_ facility level Rudhresh Kumar J
@ 2015-08-25 1:53 ` Finn Thain
0 siblings, 0 replies; 2+ messages in thread
From: Finn Thain @ 2015-08-25 1:53 UTC (permalink / raw)
To: Rudhresh Kumar J
Cc: schmitzmic, JBottomley, linux-scsi, linux-kernel,
Rudhresh Kumar J
On Tue, 30 Jun 2015, Rudhresh Kumar J wrote:
> Fixed coding style issue by adding KERN_ facility level to some of
> the printk functions.
>
> Signed-off-by: Rudhresh Kumar J <rudhresh.jk@gmail.com>
> ---
> drivers/scsi/dtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/dtc.c b/drivers/scsi/dtc.c
> index 4c74c7b..a3a2a71 100644
> --- a/drivers/scsi/dtc.c
> +++ b/drivers/scsi/dtc.c
> @@ -156,7 +156,7 @@ static int __init dtc_setup(char *str)
>
> get_options(str, ARRAY_SIZE(ints), ints);
> if (ints[0] != 2)
> - printk("dtc_setup: usage dtc=address,irq\n");
> + printk(KERN_DEBUG "dtc_setup: usage dtc=address,irq\n");
No, that is an error message that the user needs to see.
> else if (commandline_current < NO_OVERRIDES) {
> overrides[commandline_current].address = ints[1];
> overrides[commandline_current].irq = ints[2];
> @@ -272,7 +272,7 @@ found:
> instance->irq = NO_IRQ;
> #endif
> #if defined(DTCDEBUG) && (DTCDEBUG & DTCDEBUG_INIT)
> - printk("scsi%d : irq = %d\n", instance->host_no, instance->irq);
> + printk(KERN_DEBUG "scsi%d : irq = %d\n", instance->host_no, instance->irq);
> #endif
>
> ++current_override;
>
I have a better patch for this, which makes use of the dprintk macro to
replace {DTC,P,T}DEBUG_INIT with NDEBUG_INIT. Thanks anyway.
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-25 1:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-30 16:29 [PATCH] SCSI: DTC: Adding KERN_ facility level Rudhresh Kumar J
2015-08-25 1:53 ` Finn Thain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).