* [PATCH] qla2xxx: remove unused rval
@ 2015-07-22 22:08 Spencer Baugh
2015-07-22 22:17 ` Himanshu Madhani
0 siblings, 1 reply; 2+ messages in thread
From: Spencer Baugh @ 2015-07-22 22:08 UTC (permalink / raw)
To: supporter:QLOGIC QLA2XXX FC-SCSI DRIVER, James E.J. Bottomley,
open list:QLOGIC QLA2XXX FC-SCSI DRIVER, open list
Cc: Joern Engel, Spencer Baugh, Joern Engel, Spencer Baugh
From: Joern Engel <joern@logfs.org>
We don't touch the return value of qla2x00_loop_resync in
qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning.
Signed-off-by: Joern Engel <joern@logfs.org>
Signed-off-by: Spencer Baugh <sbaugh@catern.com>
---
drivers/scsi/qla2xxx/qla_os.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index a28815b..b9ee115 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4793,7 +4793,6 @@ qla2x00_disable_board_on_pci_error(struct work_struct *work)
static int
qla2x00_do_dpc(void *data)
{
- int rval;
scsi_qla_host_t *base_vha;
struct qla_hw_data *ha;
@@ -5025,7 +5024,7 @@ loop_resync_check:
if (!(test_and_set_bit(LOOP_RESYNC_ACTIVE,
&base_vha->dpc_flags))) {
- rval = qla2x00_loop_resync(base_vha);
+ qla2x00_loop_resync(base_vha);
clear_bit(LOOP_RESYNC_ACTIVE,
&base_vha->dpc_flags);
--
2.5.0.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] qla2xxx: remove unused rval
2015-07-22 22:08 [PATCH] qla2xxx: remove unused rval Spencer Baugh
@ 2015-07-22 22:17 ` Himanshu Madhani
0 siblings, 0 replies; 2+ messages in thread
From: Himanshu Madhani @ 2015-07-22 22:17 UTC (permalink / raw)
To: Spencer Baugh, Chad Dupuis, Giridhar Malavali, Saurav Kashyap,
James E.J. Bottomley, linux-scsi, linux-kernel
Cc: Joern Engel, Spencer Baugh, Joern Engel
[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]
On 7/22/15, 3:08 PM, "Spencer Baugh" <sbaugh@catern.com> wrote:
>From: Joern Engel <joern@logfs.org>
>
>We don't touch the return value of qla2x00_loop_resync in
>qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning.
>
>Signed-off-by: Joern Engel <joern@logfs.org>
>Signed-off-by: Spencer Baugh <sbaugh@catern.com>
>---
> drivers/scsi/qla2xxx/qla_os.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
>index a28815b..b9ee115 100644
>--- a/drivers/scsi/qla2xxx/qla_os.c
>+++ b/drivers/scsi/qla2xxx/qla_os.c
>@@ -4793,7 +4793,6 @@ qla2x00_disable_board_on_pci_error(struct
>work_struct *work)
> static int
> qla2x00_do_dpc(void *data)
> {
>- int rval;
> scsi_qla_host_t *base_vha;
> struct qla_hw_data *ha;
>
>@@ -5025,7 +5024,7 @@ loop_resync_check:
> if (!(test_and_set_bit(LOOP_RESYNC_ACTIVE,
> &base_vha->dpc_flags))) {
>
>- rval = qla2x00_loop_resync(base_vha);
>+ qla2x00_loop_resync(base_vha);
>
> clear_bit(LOOP_RESYNC_ACTIVE,
> &base_vha->dpc_flags);
>--
>2.5.0.rc3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
Acked-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
>
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 4568 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-22 22:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-22 22:08 [PATCH] qla2xxx: remove unused rval Spencer Baugh
2015-07-22 22:17 ` Himanshu Madhani
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox